Skip to content

feat(screenshot): allow downstream Xbox SDK to supply capture implementation#1704

Merged
tustanivsky merged 3 commits intomasterfrom
feat/native-screenshot-xbox
May 5, 2026
Merged

feat(screenshot): allow downstream Xbox SDK to supply capture implementation#1704
tustanivsky merged 3 commits intomasterfrom
feat/native-screenshot-xbox

Conversation

@tustanivsky
Copy link
Copy Markdown
Collaborator

This PR allows the downstream sentry-xbox extension to provide its own implementation of sentry__screenshot_capture by skipping the bundled Windows screenshot module when targeting Xbox.

Related items:

#skip-changelog

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against bcb7c5c

@tustanivsky tustanivsky marked this pull request as ready for review May 5, 2026 13:56
@tustanivsky
Copy link
Copy Markdown
Collaborator Author

Screenshot capturing on Xbox requires changes from this PR in the upstream repo, but those changes also depend on the feature existing in the downstream repo for the console CI checks to pass.

To work around this chicken-and-egg issue, we can merge this PR while temporarily ignoring the console/xbox failure and tag sentry-xbox with the corresponding commit SHA in sentry-native.cmake.

After getsentry/sentry-xbox#135 is merged, the console checks in the upstream repo should start passing again.

The only thing to keep in mind is that until the next release, sentry-xbox will reference sentry-native's main branch instead of the 0.14.0 release.

cc @jpnurmi

@tustanivsky tustanivsky requested a review from jpnurmi May 5, 2026 14:29
@tustanivsky tustanivsky merged commit 5893dce into master May 5, 2026
60 of 61 checks passed
@tustanivsky tustanivsky deleted the feat/native-screenshot-xbox branch May 5, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants