feat(screenshot): allow downstream Xbox SDK to supply capture implementation#1704
Merged
tustanivsky merged 3 commits intomasterfrom May 5, 2026
Merged
feat(screenshot): allow downstream Xbox SDK to supply capture implementation#1704tustanivsky merged 3 commits intomasterfrom
tustanivsky merged 3 commits intomasterfrom
Conversation
|
JoshuaMoelans
approved these changes
May 5, 2026
Collaborator
Author
|
Screenshot capturing on Xbox requires changes from this PR in the upstream repo, but those changes also depend on the feature existing in the downstream repo for the console CI checks to pass. To work around this chicken-and-egg issue, we can merge this PR while temporarily ignoring the After getsentry/sentry-xbox#135 is merged, the console checks in the upstream repo should start passing again. The only thing to keep in mind is that until the next release, cc @jpnurmi |
jpnurmi
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the downstream sentry-xbox extension to provide its own implementation of
sentry__screenshot_captureby skipping the bundled Windows screenshot module when targeting Xbox.Related items:
#skip-changelog