Skip to content

ci: pin ClangCL to windows-2022#1703

Merged
jpnurmi merged 2 commits intomasterfrom
jpnurmi/ci/windows
May 5, 2026
Merged

ci: pin ClangCL to windows-2022#1703
jpnurmi merged 2 commits intomasterfrom
jpnurmi/ci/windows

Conversation

@jpnurmi
Copy link
Copy Markdown
Collaborator

@jpnurmi jpnurmi commented May 5, 2026

GitHub just switched windows-latest to windows-2025-vs2026, and it broke the ClangCL build that requests VS 2022:

def configure_clang_cl(config_cmd: list[str]):
config_cmd.append("-G Visual Studio 17 2022")
config_cmd.append("-A x64")
config_cmd.append("-T ClangCL")

Which cannot be found on windows-2025-vs2026:

Visual Studio 17 2022

could not find any instance of Visual Studio.

GitHub just switched windows-latest to windows-2025-vs2026 and it broke
the ClangCL build:

>    Visual Studio 17 2022
>
>  could not find any instance of Visual Studio.
Comment thread .github/workflows/ci.yml Outdated
@jpnurmi jpnurmi merged commit 2ab9aeb into master May 5, 2026
54 checks passed
@jpnurmi jpnurmi deleted the jpnurmi/ci/windows branch May 5, 2026 13:42
Comment thread .github/workflows/ci.yml
- name: Windows ClangCL (latest)
os: windows-latest
- name: Windows ClangCL (2022)
os: windows-2022
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, I got confused by the Windows and Visual Studio versions. This probably should've been windows-2025 which comes with VS 2022... 😭

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants