fix(astro): resolve middleware export types#21414
Open
itosa-kazu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21413.
Summary
@sentry/astro/middlewareexporttypescondition at the emittedindex.d.tsdeclaration file.MiddlewareResponseHandleralias from the middleware subpath declaration, so the published declaration remains readable for supported Astro versions where that alias is absent.handleRequest().Validation
git diff --checkexports[./middleware].typesis./build/types/integration/middleware/index.d.ts@sentry/astro@10.57.0,astro@5.16.6, andtypescript@5.9.3: original package reproducesTS7016; patched package metadata plus the expected declaration shape passesnpx tsc --noEmit; runtime import still exportsonRequest.A direct package type-check in this sparse checkout was not runnable because the checkout/install did not include linked Sentry workspace packages such as
@sentry/core,@sentry/browser, and@sentry/node.