[codex] Add WxS identifiers to web service modal#210
Merged
Conversation
- Updated LinkService to include WxS identifiers in web service links, improving the detail provided for OGC services. - Refactored the _get_web_services_links method to return additional request URLs and labels for WMS, WFS, and WCS services. - Enhanced LinksTable component to display WxS identifiers and service URLs, with copy functionality for better user experience. - Added tests to verify the inclusion of WxS identifiers in service links and ensure correct rendering in the LinksTable. These changes improve the functionality and usability of the link services within the application. Fixes #175
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #175.
This updates the web services link flow so OGC service entries expose the pieces users need separately and safely:
gbl_wxsIdentifier_slayer identifier when presentFor WMS, the helper request now builds a layer-scoped
GetMappreview using the resource bbox andEXCEPTIONS=application/vnd.ogc.se_inimage, so GeoServer layer errors open in the browser as an image response instead of downloading XML. This avoids provider-wideGetCapabilitiescalls and keeps the preview scoped to the resource.Validation
python -m pytest backend/tests/services/test_link_service.pynpm test -- LinksTable.test.tsx --runruff check backend/app/services/link_service.py backend/tests/services/test_link_service.pyNote: repo-wide frontend lint/format currently reports unrelated pre-existing failures outside this change.