Skip to content

fix: resolve getSlashingAddress removed from SDK in validator-history#344

Open
ygd58 wants to merge 1 commit into
genlayerlabs:v0.39from
ygd58:fix/validator-history-slashing-address
Open

fix: resolve getSlashingAddress removed from SDK in validator-history#344
ygd58 wants to merge 1 commit into
genlayerlabs:v0.39from
ygd58:fix/validator-history-slashing-address

Conversation

@ygd58

@ygd58 ygd58 commented Jun 6, 2026

Copy link
Copy Markdown

Summary

Fixes genlayer staking validator-history failing with client.getSlashingAddress is not a function.

Root Cause

getSlashingAddress() was removed from genlayer-js SDK in v0.39+. The validatorHistory.ts command still called it, causing an immediate crash before any history could be fetched.

Fix

Replaced client.getSlashingAddress() with a dynamic lookup via viem readContract — reads the idleness contract address from the consensusMainContract on-chain. Falls back to the staking contract address if resolution fails, ensuring reward events still display correctly.

Related Issue

Fixes #341

getSlashingAddress() was removed from genlayer-js SDK (v0.39+).
This caused 'client.getSlashingAddress is not a function' error
when running 'genlayer staking validator-history'.

Fix: dynamically read idleness contract address from consensusMain
contract via viem readContract. Falls back to staking address if
resolution fails, so reward events still work.

Fixes genlayerlabs#341
@coderabbitai

coderabbitai Bot commented Jun 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@ygd58, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 25 minutes and 7 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dd6c3f1a-8492-4ac7-a831-b1023b79aca3

📥 Commits

Reviewing files that changed from the base of the PR and between ca083ab and 193cf21.

📒 Files selected for processing (1)
  • src/commands/staking/validatorHistory.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] staking validator-history fails: "client.getSlashingAddress is not a function"

1 participant