fix: resolve getSlashingAddress removed from SDK in validator-history#344
fix: resolve getSlashingAddress removed from SDK in validator-history#344ygd58 wants to merge 1 commit into
Conversation
getSlashingAddress() was removed from genlayer-js SDK (v0.39+). This caused 'client.getSlashingAddress is not a function' error when running 'genlayer staking validator-history'. Fix: dynamically read idleness contract address from consensusMain contract via viem readContract. Falls back to staking address if resolution fails, so reward events still work. Fixes genlayerlabs#341
|
Warning Review limit reached
More reviews will be available in 25 minutes and 7 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes
genlayer staking validator-historyfailing withclient.getSlashingAddress is not a function.Root Cause
getSlashingAddress()was removed fromgenlayer-jsSDK in v0.39+. ThevalidatorHistory.tscommand still called it, causing an immediate crash before any history could be fetched.Fix
Replaced
client.getSlashingAddress()with a dynamic lookup via viemreadContract— reads the idleness contract address from theconsensusMainContracton-chain. Falls back to the staking contract address if resolution fails, ensuring reward events still display correctly.Related Issue
Fixes #341