Change checkSourceLengthRule to use Span.IsWhiteSpace instead of Stri…#854
Open
Numpsy wants to merge 1 commit intofsprojects:masterfrom
Open
Change checkSourceLengthRule to use Span.IsWhiteSpace instead of Stri…#854Numpsy wants to merge 1 commit intofsprojects:masterfrom
Numpsy wants to merge 1 commit intofsprojects:masterfrom
Conversation
…ng.Trim String.Trim can allocate a new string on each call, whereas Span.IsWhiteSpace() shouldn't allocate at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ng.Trim
String.Trim can allocate a new string on each call, whereas Span.IsWhiteSpace() shouldn't allocate at all.
Just a thought when looking at some Span related things.
If I run the existing benchmark app using the rule set which is enabled during the SelfCheck part of the CI build then I get this with the current code
And this afterwards
A small change improvement given the total allocations, but also a small change so I thought it'd still be useful.