Build system, platform, and deployment fixes#912
Open
sreckoskocilic wants to merge 7 commits into
Open
Conversation
…paring two tuples, every equality check returns True - master -> main branch fix - prepare_trash now calls self.move_to_trash instead of self.delete, so plugin subclasses won't permanently delete files when the user expects trashing - NotImplementedError - unrecognized platforms fail fast with a clear message instead of a cryptic NameError - removed shadowing basename import - get_column_widths uses range so plugin-added columns get their widths saved/restored
…it__ always runs, even on exception. - util/qt/__init__.py — Added missing c_void_p import from ctypes, fixing a macOS runtime crash. - table.py — Fixed off-by-one: bounds check now rejects len + 1 correctly. - widgets.py — Added null guard on _main_window before accessing it in state change handler.
…ved, so a/b/c/../../d correctly becomes a/d. - session.py — Removed dead _get_startup_message method (duplicated by _show_startup_messages)
- desk.cmd — auto-detect Windows SDK, relative paths, add sign/publish aliases - build.py — remove unused import, Debian support in publish, bare except→except Exception, assert→ValueError - build_impl/init.py — hasattr(__path__) for package detection, dest_path bugfix, utf-8 fallback encoding, assert→RuntimeError, chmod check=True, skip .git in cleanup, master→main, HTTPS validation + timeout - aws.py — unique CallerReference - mac.py — altool→notarytool (modern Apple notarization API), removed unused imports - ubuntu.py — dynamic GTK path via ctypes, removed stale libpng12 exception - Settings — fedora hidden_imports, mac team_id, windows timestamp server update - fedora.repo — gpgcheck=1 + gpgkey - post-commit — FMAN_API_SECRET env var (removes hardcoded secret), --fail --silent on curl - install.txt — updated URLs, NSIS version, placeholder for cert path - requirements — http→https, remove duplicate PyQt5 in windows.txt, arch.txt comment - CHANGELOG.md — QtQmlModels added to strip list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build system
venv→.venvacross.gitignore,desk.sh,desk.cmd, and all 3 Dockerfiles (arch, fedora, ubuntu)desk.cmd— auto-detect Windows SDK version instead of hardcoded path; relativeROOTpath; addedsignandpublishaliasesbuild.py— bareexcept:→except Exception:;assert→raise ValueErrorinpost_release; Debian added to publish targetsbuild_impl/__init__.py—is_packagedetection useshasattr(library, '__path__')instead of filename regex;dest_dir→dest_pathtypo fix inupload_file;.decode()fallback toutf-8whensys.stdout.encodingis None;master→mainbranch for GitHub push;.gitexcluded from cleanup during core uploadbuild_impl/aws.py— CloudFront invalidationCallerReferenceusesid(items)suffix to avoid collisionsmacOS
altool→notarytool— deprecatedxcrun altoolreplaced withxcrun notarytool submit --wait; removesplistlib,requests,json,sleepdependencies; adds--team-idsettingmac.json— addedapple_developer_team_idfieldLinux
libpng12exception in GTK dependency removal;find_library('gtk-3')replaces hardcoded.sopathhidden_importsforpgi.overridesin settings;gem install --no-documentreplaces deprecated--no-ri --no-rdocpgiis excluded from requirementsWindows
PyQt5==5.15.11removed fromrequirements/windows.txt(already inbase.txt)Docs
install.txt— updated Xcode download URL, NSIS version note, timestamp server, removed hardcoded pathsCHANGELOG.md— addedQtQmlModelsto list of excluded Qt frameworksTest plan
desk.cmdauto-detects Windows SDK on a Windows machinenotarytoolpython build.py freezeworks on each platform