Skip to content

fix(share_plus): avoid iOS 26 share sheet crash for non-image files #3813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MohamedAbdallah-14 wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −1
Open

fix(share_plus): avoid iOS 26 share sheet crash for non-image files #3813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/share_plus/share_plus/ios/share_plus/Sources/share_plus/FPPSharePlusPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,19 @@ - (LPLinkMetadata *)activityViewControllerLinkMetadata:
}

// https://stackoverflow.com/questions/60563773/ios-13-share-sheet-changing-subtitle-item-description
metadata.originalURL = [NSURL fileURLWithPath:description];
// The fake file URL above is a long-standing trick used to surface the
// file size/extension as a subtitle in the share sheet. iOS 26 introduced
// stricter validation of LPLinkMetadata.originalURL: when the share sheet
// tries to fetch link metadata (SHSheetActivityItemsManager) for the
// bogus URL — for example when sharing .docx files — it crashes with
// "*** -[__NSArrayM insertObject:atIndex:]: object cannot be nil".
// Skip the fake URL on iOS 26+ and accept the loss of the subtitle in
// exchange for not crashing. See issue #3784.
if (@available(iOS 26.0, *)) {
// Leave metadata.originalURL nil.
} else {
metadata.originalURL = [NSURL fileURLWithPath:description];
}
if (_mimeType && [_mimeType hasPrefix:@"image/"]) {
UIImage *image = [UIImage imageWithContentsOfFile:_path];
metadata.imageProvider = [[NSItemProvider alloc]
Expand Down
Loading