Show debug-mode message for widget rebuilds in profile mode by crackedhandle · Pull Request #9755 · flutter/devtools

crackedhandle · 2026-04-03T00:28:11Z

Problem

When running in profile mode, the Performance panel showed a
disabled "Count widget builds" checkbox which was misleading -
it implies the feature could work if enabled. In reality, widget
rebuild counts rely on debugOnRebuildDirtyWidget which is only
available in debug mode.

Solution

Removes the checkbox when running in profile mode
Replaces it with a clear message:

"Rebuild information is not available for this frame.
Widget rebuild counts are only available when running
an app in debug-mode."

Tests

Added rebuild_stats_view_test.dart with two widget tests:

Verifies the message appears in profile mode
Verifies the normal UI appears in debug mode

crackedhandle · 2026-04-07T15:47:10Z

@elliette can you review this?

elliette · 2026-04-07T23:37:24Z

+      selectedFrame = ValueNotifier<FlutterFrame?>(null);
+    });
+
+    testWidgets(


Could we add these tests cases to the performance_screen_test instead of creating a new test suite? Thanks!

Please review the required changes @elliette ! thanks

crackedhandle · 2026-04-17T22:08:30Z

I see CI is failing due to lint warnings in DevTools files that I haven’t modified. Should I address these as part of this PR, or is there a preferred way to handle them? @srawlins

srawlins · 2026-04-17T23:04:47Z

I think those are the result of a new version of analyzer... or Dart... or even DCM I guess. So we just have to fix them out-of-band. Probably someone should fix them and land that fix before landing other PRs.

crackedhandle · 2026-04-18T16:15:30Z

I think those are the result of a new version of analyzer... or Dart... or even DCM I guess. So we just have to fix them out-of-band. Probably someone should fix them and land that fix before landing other PRs.

Got it, thanks for the clarification. I’ll wait for the lint fixes to land and re-run CI afterward.

When running in profile mode, the Performance panel showed a disabled 'Count widget builds' checkbox which was misleading. Widget rebuild counts rely on debugOnRebuildDirtyWidget which is only available in debug mode. This change: - Removes the checkbox when running in profile mode - Shows a clear message: 'Rebuild information is not available for this frame. Widget rebuild counts are only available when running an app in debug-mode.' - Adds widget tests for both profile mode and debug mode behavior Fixes flutter#9730

Per reviewer feedback, moved the profile mode widget tests from a separate test file into the existing performance_screen_test.dart. Also added required imports for RebuildStatsView, RebuildCountModel, FlutterFrame and foundation.

crackedhandle · 2026-04-20T22:32:12Z

@srawlins Rebased. can we try again to re-run the tests?

crackedhandle · 2026-04-20T22:41:49Z

Yay!, DCM test passed. Thanks @srawlins and @elliette for the guidance and help.

crackedhandle · 2026-04-22T16:07:52Z

@srawlins all checks are passing now. Please let me know if there’s anything else I should address, otherwise this should be ready for merge.

kenzieschmoll · 2026-05-04T20:20:18Z

+      return const Center(
+        child: Text(


Use CenteredMessage instead

kenzieschmoll · 2026-05-04T20:22:30Z

 includes the following changes among other general improvements.
 To learn more about DevTools, check out the
-[DevTools overview](/tools/devtools).
+[DevTools overview](https://docs.flutter.dev/tools/devtools).


please revert this change. This link is intentionally relative because these notes are copied to the Flutter website

kenzieschmoll · 2026-05-04T20:22:58Z

- Fixed an issue where navigating the Inspector widget tree with the keyboard arrow keys did not update the selected widget in the connected Flutter app. [#9810](https://github.com/flutter/devtools/pull/9810)
- Fixed an issue where clicking a widget row after collapsing a subtree with the left arrow key unexpectedly re-expanded the subtree. [#9810](https://github.com/flutter/devtools/pull/9810)
- Fixed an issue where collapsing the Inspector widget tree to a single row with the left arrow key caused a loading spinner to appear instead of showing the root node. [#9810](https://github.com/flutter/devtools/pull/9810)
+TODO: Remove this section if there are not any updates.


revert all local changes to this file other than the entry you want to add. thanks!

kenzieschmoll · 2026-05-04T20:23:56Z

        },
      );

-      // testWidgetsWithWindowSize(


please revert this change since it is unrelated to this PR. I'm not sure why this test was commented out, but we can address this separately.

kenzieschmoll · 2026-05-04T20:25:24Z

+        when(app.isDartWebAppNow).thenReturn(false);
+        when(app.isFlutterAppNow).thenReturn(true);
+        when(app.isDartCliAppNow).thenReturn(false);
+        when(app.isDartWebApp).thenAnswer((_) async => false);
+        when(app.isProfileBuild).thenAnswer((_) async => false);


instead of doing this, use the mockConnectedApp test helper

crackedhandle requested a review from kenzieschmoll as a code owner April 3, 2026 00:28

elliette requested changes Apr 7, 2026

View reviewed changes

crackedhandle requested a review from elliette April 10, 2026 11:18

crackedhandle requested a review from a team as a code owner April 14, 2026 16:52

srawlins requested changes Apr 14, 2026

View reviewed changes

crackedhandle requested a review from srawlins April 14, 2026 18:35

srawlins approved these changes Apr 16, 2026

View reviewed changes

crackedhandle requested a review from srawlins April 16, 2026 07:28

srawlins approved these changes Apr 16, 2026

View reviewed changes

elliette requested changes Apr 16, 2026

View reviewed changes

Comment thread packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md

Comment thread packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md

crackedhandle requested review from elliette and srawlins April 16, 2026 16:19

elliette requested changes Apr 16, 2026

View reviewed changes

Comment thread packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md Outdated

Comment thread packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md

crackedhandle requested a review from elliette April 16, 2026 19:42

srawlins approved these changes Apr 17, 2026

View reviewed changes

crackedhandle force-pushed the fix-widget-rebuilds-profile-mode branch from 96a4f70 to 788a58e Compare April 20, 2026 22:06

crackedhandle added 9 commits April 21, 2026 03:37

Move RebuildStatsView tests to performance_screen_test

e1c52f3

Per reviewer feedback, moved the profile mode widget tests from a separate test file into the existing performance_screen_test.dart. Also added required imports for RebuildStatsView, RebuildCountModel, FlutterFrame and foundation.

Fix formatting and add release note

23d9d05

Resolve merge conflict in release notes

a9febdd

style: format performance_screen_test

0879481

fix: restore removed tests and apply only required changes

808bf1a

style: format file and add required comments

d6ff5d2

fix: properly remove build artifacts

2b176c3

Remove unnecessary imports

05507a2

crackedhandle force-pushed the fix-widget-rebuilds-profile-mode branch from 788a58e to 05507a2 Compare April 20, 2026 22:29

crackedhandle requested a review from srawlins April 20, 2026 22:32

incendial mentioned this pull request Apr 21, 2026

attempt to clean up DCM issues #9791

Closed

crackedhandle force-pushed the fix-widget-rebuilds-profile-mode branch from 93b76d4 to 05507a2 Compare April 23, 2026 05:36

Merge branch 'master' into fix-widget-rebuilds-profile-mode

560df3a

kenzieschmoll reviewed May 4, 2026

View reviewed changes

Conversation

crackedhandle commented Apr 3, 2026

Problem

Solution

Tests

Uh oh!

crackedhandle commented Apr 7, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

crackedhandle commented Apr 17, 2026

Uh oh!

srawlins commented Apr 17, 2026

Uh oh!

crackedhandle commented Apr 18, 2026

Uh oh!

crackedhandle commented Apr 20, 2026

Uh oh!

crackedhandle commented Apr 20, 2026

Uh oh!

crackedhandle commented Apr 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants