[flutter_hook_config] Add the flutter_hook_config package#19
Conversation
|
Migrated from flutter/packages#11701. FYI @dcharkes, I also updated this to use hooks v2. |
|
Copying publishing notes from previous PR: Note for shipping this: Also flagging: the top-level |
|
I am not aware of this being owned by the framework team. Let's discuss if that is expected. Removing the triage label for now. |
|
@Piinks Ah whoopsies, I added that label by accident. This is more tools-esque. |
dcharkes
left a comment
There was a problem hiding this comment.
All the comments from flutter/packages#11701 have been addressed. LGTM!
Except it isn't a new package; what appears to be a placeholder package, with no useful metadata about where it came from, was published 5 months ago. So the publishing failed. Does one of you own that package? (The only clue to ownership I can find in the package is that it is "Copyright 2025, the Dart project authors", so hopefully that means someone on the Dart team is the package owner.) |
|
Ugh, no. I thought I had checked if the name was taken, but I guess not. :/ This was actually my second choice name, as the first name I chose was also taken. Another good name would be |
|
I'm also not owning it. But it seems that package is just being name-squatted, which is against the pub.dev policy: https://pub.dev/policy#name-squatting I've pinged the pub team to unsquat it. |
Towards flutter/flutter#186299
Adds
flutter_hook_config, apackage:hooksprotocol extension owned by Flutter. It lets the Flutter SDK pass engine host-tool paths (such asimpellercandlibtessellator) to build and link hooks in a typed way, resolved through the same artifact lookupflutter_toolsuses for its own build steps, so--local-enginepropagates to hooks instead of silently using stale cached tools.Originally proposed in flutter/packages#11701. Per review there, the package belongs in this repo:
flutter_toolsdepends on it, so keeping it in flutter/packages would create a circular repo dependency. This moves it here unchanged apart from the repo onboarding bits (SDK constraint, allowed dependencies, labeler, README) and a bump tohooks: ^2.0.0.What a Flutter build hook looks like with it:
v1 exposes
impellerc,libtessellator, and anengineVersionfor cache invalidation; more host artifacts can be added later as null-checked fields. Pure Dart, depends onhooks: ^2.0.0, starts at0.1.0while the shape stabilizes.Pre-Review Checklist
[vector_math]///).