Skip to content

Auto-update dependencies.#2805

Merged
thatfiredev merged 1 commit into
masterfrom
dpebot-repositorygardener
Jun 10, 2026
Merged

Auto-update dependencies.#2805
thatfiredev merged 1 commit into
masterfrom
dpebot-repositorygardener

Conversation

@dpebot

@dpebot dpebot commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Brought to you by your friendly Repository Gardener.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the compileSdk and targetSdk versions from 36 to 37 across multiple modules, and bumps the androidx.core:core-ktx dependency version from 1.18.0 to 1.19.0. The review feedback suggests utilizing the centralized version catalog (libs.androidx.core.ktx) in the firestore and messaging modules instead of hardcoding the dependency versions, ensuring consistency and preventing version drift.

implementation("androidx.activity:activity-ktx:1.13.0")
implementation("androidx.appcompat:appcompat:1.7.1")
implementation("androidx.core:core-ktx:1.18.0")
implementation("androidx.core:core-ktx:1.19.0")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of hardcoding the dependency version, use the centralized version catalog reference 'libs.androidx.core.ktx' to maintain consistency across all modules and avoid version drift.

    implementation(libs.androidx.core.ktx)

implementation("androidx.annotation:annotation:1.10.0")
implementation("androidx.vectordrawable:vectordrawable-animated:1.2.0")
implementation("androidx.core:core-ktx:1.18.0")
implementation("androidx.core:core-ktx:1.19.0")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of hardcoding the dependency version, use the centralized version catalog reference 'libs.androidx.core.ktx' to maintain consistency across all modules and avoid version drift.

    implementation(libs.androidx.core.ktx)

@thatfiredev thatfiredev merged commit 40e343c into master Jun 10, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants