Open
Conversation
pbukva
changed the title
Temporarily Disabling due to dual import of `ibc-go` module `v8@v8.4.0` and `v10@v10.3.0`, what causes conflicts when each version of the `ibc-go` module registers the very same set of errors in the *GLOBAL* scope via `errorsmod.Register(...)`. This happens due to the fact, that this particular test depends on the `strangelove-ventures/interchaintest/v8@v8.8.1 `module, which depends on `ibc-go/v8@v8.4.0`, however our fetchai/tokenfactory depends on `ibc-go/v10@v10.3.0`. At the moment, this is hard to resolve, since the strangelove-ventures/interchaintest would need to be forked, and updated so it would depend on `CosmWasm/wasmd@v0.61.2`, `CosmWasm/wasmvm/v3@v3.0.0` and `ibc-go/v10@v10.3.0`, what is non-trivial task, hence disabling this test temporarily. ------------- * fix: Attempted simulator fix * fix: WasmVM version in Dockerfile * Disabling the 'interchaintest/tokenfactory_test.go' test Disabling the test due to dual import of ibc-go module v8@v8.4.0 and v10@v10.3.0, what causes conflicts when each version of ibc-go module registers the very same set of errors in the *GLOBAL* scope via `errorsmod.Register(...)`. This happens due to the fact, that this particular test depends on the strangelove-ventures/interchaintest/v8@v8.8.1 module, which depends on ibc-go/v8@v8.4.0, however our fetchai/tokenfactory depends on ibc-go/v10@v10.3.0. At the moment, this is hard to resolve, since the strangelove-ventures/interchaintest would need to be forked, and updated so it would depend on CosmWasm/wasmd@v0.61.2, CosmWasm/wasmvm/v3@v3.0.0 and ibc-go/v10@v10.3.0, what is non-trivial task, hence disabling this test temporarily. TODO(pb): The test shall be re-enabled once the issue with the strangelove-ventures/interchaintest module is resolved. * Marking all E2E test as skipped in GH workflow * Marking all E2E test as skipped in GH workflow --------- Co-authored-by: Peter Bukva <peter.bukva@gmail.com>
pbukva
changed the title
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
pbukva
force-pushed
the
feat/dropping_sudo_admins_concept
branch
from
933d804 to
b0c352c
Compare
pbukva
commented
May 9, 2026
Comment on lines
+116
to
+120
| // Denomination *MUST* already exist: | ||
| _, denomExists := server.bankKeeper.GetDenomMetaData(ctx, msg.Amount.Denom) | ||
| if !denomExists { | ||
| return nil, types.ErrDenomDoesNotExist.Wrapf("denom: %s", msg.Amount.Denom) | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This was added only to make the behaviour symmetrical with the Mint(...).
👉 HOWEVER, it is questionable whether this is really necessary. I do not see a strong argument for enforcing the presence of denom metadata in the bank module.
pbukva
commented
May 9, 2026
Comment on lines
+57
to
+61
| // Denomination *MUST* already exist: | ||
| _, denomExists := server.bankKeeper.GetDenomMetaData(ctx, msg.Amount.Denom) | ||
| if !denomExists { | ||
| return nil, types.ErrDenomDoesNotExist.Wrapf("denom: %s", msg.Amount.Denom) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.