Conversation
Bordado's function to create random coordinates generates a different set of random coordinates than using Verde's function. This leads to a slightly different memory estimation for equivalent sources.
leouieda
requested changes
Apr 28, 2026
Member
leouieda
left a comment
leouieda
left a comment
There was a problem hiding this comment.
Looks great! Made some small suggestions. I also noticed that Bordado is missing from the list in https://www.fatiando.org/harmonica/dev/install.html#dependencies (Boule is too, actually).
leouieda
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
bordadoas required dependency. Replace some of the Verde functions (likegrid_coordinates,get_region,rolling_window, etc.) for their Bordado counterparts in source code, tests, and docs. Update the code that uses those functions: keep in mind that Bordado functions are n-dimensional, so additional coordinates are not ignored as in Verde ones.Relevant issues/PRs:
Fixes #656