Release v2.63.0 by CarterLi · Pull Request #2320 · fastfetch-cli/fastfetch

CarterLi · 2026-05-11T01:57:06Z

Checklist

I have tested my changes locally.

... and improve performance slightly

* Packages:add cards counting (NuTyX) * package.c no need to add counts.catds * Sort packages print alphabetically * ditto * ditto * packages.c update FF_ARG and ffpackagesModule.info --------- Co-authored-by: Carter Li <CarterLi@users.noreply.github.com>

Co-authored-by: Copilot <copilot@github.com>

Noop, because the whole platform is statically initialized Co-authored-by: Copilot <copilot@github.com>

Co-authored-by: Copilot <copilot@github.com>

Co-authored-by: or sim <you@example.com>

Co-authored-by: Copilot <copilot@github.com>

* Wallpaper (Haiku): Add support * Refactor wallpaper detection logic and memory handling --------- Co-authored-by: Carter Li <CarterLi@users.noreply.github.com>

Fixes #2319

* Logo: Add openRuyi * Update ASCII art in openruyi.txt * Fix casing of 'openRuyi' in builtin.c --------- Co-authored-by: Z572 <z572@z572.online> Co-authored-by: Carter Li <CarterLi@users.noreply.github.com>

Copilot

Pull request overview

Release bump to v2.63.0, bundling a broad set of platform detection improvements (notably Linux Wi-Fi via netlink, Windows battery/media refactors, Wayland protocol compatibility updates), plus new logos and assorted reliability fixes across common utilities.

Changes:

Refactors platform detection: Linux Wi-Fi switches to nl80211 netlink; Windows battery detection moves to WMI data blocks; Windows media detection is integrated (WinRT headers gated at build time).
Updates Wayland displayserver bindings to handle newer protocol versions more safely, and adds Haiku wallpaper detection.
Adds/adjusts package counting, OS flavor detection, parsing/validation hardening, and new builtin logos.

Reviewed changes

Copilot reviewed 95 out of 95 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/options/display.c	Formats enum parsing; validates `ndigits` range on CLI.
src/modules/wifi/wifi.c	Fixes band selection logic (avoid overwriting 60 GHz).
src/modules/packages/packages.c	Adds `cards` package manager reporting throughout module output/JSON.
src/modules/packages/option.h	Adds disable flag bit for `cards`.
src/modules/battery/option.h	Removes Windows-only `useSetupApi` option from battery options.
src/modules/battery/battery.c	Removes JSON parsing/config emission for `useSetupApi`.
src/logo/builtin.c	Adds/adjusts builtin logos (GNOME OS name match, new KibaOS/NebiOS/openRuyi/XJ380, removals/format tweaks).
src/logo/ascii/xj380.txt	Adds XJ380 ASCII logo.
src/logo/ascii/openruyi.txt	Adds openRuyi ASCII logo.
src/logo/ascii/nebios.txt	Adds NebiOS ASCII logo.
src/logo/ascii/kibaos.txt	Adds KibaOS ASCII logo.
src/detection/wifi/wifi.h	Improves frequency→channel mapping (2.4/5/6 GHz + special cases).
src/detection/wifi/wifi_linux.c	Replaces Linux Wi-Fi detection approach with nl80211 netlink + ioctl fallback and richer parsing.
src/detection/wallpaper/wallpaper_haiku.cpp	Implements Haiku wallpaper path detection.
src/detection/terminalshell/terminalshell.c	Adjusts Konsole version detection for likely TDE Konsole (#2319).
src/detection/terminalshell/terminalshell_windows.c	Minor formatting/indent fixes in registry read block.
src/detection/sound/sound_windows.cpp	Switches to new COM helper header; initializes COM pointers explicitly.
src/detection/publicip/publicip.c	Fixes typo in sentinel macro name (`FF_UNINITIALIZED`).
src/detection/packages/packages.h	Adds `cards` field to package result struct.
src/detection/packages/packages_linux.c	Implements `cards` counting for NuTyX.
src/detection/os/os_linux.c	Adds Ubuntu Kylin/Unity detection; improves Deepin version; adjusts Bedrock helper attributes.
src/detection/media/media_windows.dll.h	Removes separate WinRT media DLL interface header.
src/detection/media/media_windows.dll.cpp	Removes separate WinRT media DLL implementation.
src/detection/media/media_windows.cpp	Adds integrated Windows media detection (WinRT-gated) + thumbnail saving.
src/detection/media/media_windows.c	Removes old dynamic DLL loader for WinRT media.
src/detection/host/host_linux.c	Minor whitespace cleanup.
src/detection/gtk_qt/gtk.c	Treats NebiDE as GNOME-settings-based theme source.
src/detection/displayserver/linux/wayland/zwlr-output.c	Makes listener static; caps bind version.
src/detection/displayserver/linux/wayland/wayland.h	Adds local `min()` helper for bind-version capping.
src/detection/displayserver/linux/wayland/kde-output.c	Caps bind versions; listener adjustments; makes order listener static.
src/detection/displayserver/linux/wayland/kde-output-device-v2-protocol.c	Updates protocol version/event counts for newer kde-output-device-v2.
src/detection/displayserver/linux/wayland/kde-output-device-v2-client-protocol.h	Syncs client protocol header with newer events/capabilities and doc fixes.
src/detection/displayserver/linux/wayland/global-output.c	Caps wl_output/zxdg bind versions; annotates API used.
src/detection/displayserver/displayserver.h	Adds NebiDE DE pretty-name constant.
src/detection/camera/camera_windows.cpp	Uses new COM helper header; adds Display P3 colorspace enum handling.
src/detection/brightness/brightness_windows.cpp	Removes C++ WMI-based brightness implementation.
src/detection/brightness/brightness_windows.c	Adds C implementation using WMI data blocks + DDC/CI fallback with extra debug logging.
src/detection/bluetooth/bluetooth_windows.cpp	Removes C++ WMI-based Bluetooth battery implementation.
src/detection/bluetooth/bluetooth_windows.c	Adds C implementation using CM device properties for Bluetooth battery level.
src/detection/battery/battery_windows.c	Refactors Windows battery detection to WMI data blocks + NT API (removes old CM/SetupAPI toggle).
src/common/windows/wmi.hpp	Removes C++ WMI wrapper.
src/common/windows/wmi.h	Adds C declarations/helpers for WMI data block APIs.
src/common/windows/wmi.cpp	Removes C++ WMI implementation.
src/common/windows/version.c	Simplifies Win32 error logging.
src/common/windows/nt.h	Fixes SharedUserData access for aarch64; improves Win11 detection.
src/common/windows/com.hpp	Removes C++ COM helper header.
src/common/windows/com.h	Adds C/C++ compatible COM helper header + cleanup macro.
src/common/windows/com.cpp	Removes C++ COM init implementation.
src/common/windows/com.c	Adds C COM/WinRT init implementation (RoInitialize/CoInitializeEx).
src/common/impl/temps.c	Validates JSON temp thresholds are integers before parsing.
src/common/impl/sysctl.c	Fixes sysctl error handling; minor cleanup.
src/common/impl/settings.c	Fixes DBus reply unref leaks in XFConf getters.
src/common/impl/properties.c	Fixes typo (“quoted”).
src/common/impl/percent.c	Avoids formatting sentinel (-DBL_MAX) as a number; moves bar calc into colored path.
src/common/impl/path.c	Simplifies Windows `frealpath` return flow.
src/common/impl/parsing.c	Extends GTK combination logic to handle GTK2+GTK4 case.
src/common/impl/option.c	Hardens numeric parsing (range checks) and asserts prefix args non-null.
src/common/impl/networking_windows.c	Fixes Content-Length offset; reorganizes validity checks and mismatch handling.
src/common/impl/networking_linux.c	Same Content-Length offset + validation reorder as Windows.
src/common/impl/networking_common.c	Improves gzip decompression correctness and buffer sizing.
src/common/impl/netif_windows.c	Uses AF_INET/AF_INET6 routing tables; improves default route selection.
src/common/impl/netif_haiku.c	Fixes IPv6 route socket family.
src/common/impl/netif_gnu.c	Fixes NUL-termination when no interface found.
src/common/impl/netif_bsd.c	Replaces assert with bounds check for interface name length.
src/common/impl/netif_apple.c	Improves route response matching and adds bounds checks.
src/common/impl/library.c	Minor preprocessor/parentheses fixes in Windows dl* implementation.
src/common/impl/jsonconfig.c	Fixes CPUUsage prepare routing; corrects “condition” property error text.
src/common/impl/io_windows.c	Improves console mode handling and avoids terminal response buffer overflow.
src/common/impl/io_unix.c	Switches directory traversal to O_DIRECTORY + auto-close DIR.
src/common/impl/init.c	Adjusts default cursor/linewrap behavior; improves sigaction initialization; updates feature list.
src/common/impl/format.c	Fixes `FF_ARG_TYPE_INT` handling and adds `FF_ARG_TYPE_UINT64`.
src/common/impl/font.c	Improves Xft parsing (pointsize) and avoids storing empty styles.
src/common/impl/FFstrbuf.c	Fixes separator matching bounds and avoids over-reads.
src/common/impl/FFPlatform.c	Initializes `pageSize` before platform init.
src/common/impl/FFPlatform_windows.c	Documents correct free sequence for LSA username.
src/common/impl/FFPlatform_unix.c	Adds missing includes; fixes pid type cast on OpenBSD.
src/common/impl/FFlist.c	Adds `__restrict` for shift/pop out params.
src/common/impl/dbus.c	Fixes byte-array string extraction; hardens UINT→INT conversion.
src/common/impl/commandoption.c	Returns structured JSON error for unknown module types.
src/common/impl/binary_windows.c	Uses bounded `strnlen` when scanning PE sections.
src/common/impl/binary_linux.c	Uses bounded `strnlen` when scanning ELF sections.
src/common/impl/binary_apple.c	Skips short strings properly; minor cleanup.
src/common/FFlist.h	Mirrors `__restrict` signature changes for shift/pop.
src/common/apple/smc_temps.c	Removes unused math include.
src/common/apple/osascript.m	Removes unused Apple framework imports.
src/common/apple/cf_helpers.c	Fixes CFData int size assumptions for int32_t.
src/3rdparty/display-library/repo.json	Updates embedded ADL SDK version metadata to 18.1.
src/3rdparty/display-library/adl_structures.h	Updates/adjusts ADL structures for newer Windows-focused SDK.
src/3rdparty/display-library/adl_sdk.h	Bumps ADL SDK version macros; removes Linux __stdcall shim.
src/3rdparty/display-library/adl_defines.h	Updates ADL defines/enums for newer SDK; doc adjustments.
doc/json_schema.json	Removes `useSetupApi` from battery JSON schema.
CMakeLists.txt	Windows: C++20, WinRT header detection, link/runtime defs changes; replaces WinRT DLL build with integrated path; enables Haiku wallpaper source.
CHANGELOG.md	Adds 2.63.0 release notes.
.github/workflows/build-omnios-amd64.yml	Makes `pkg update` non-fatal for OmniOS CI.
.github/pull_request_template.md	Adds screenshots section to PR template.

+    if (pos + 2 > len) {
+        return;
+    }
+    uint16_t pairwiseCount = *(uint16_t*) (ie + pos);
+    pos += 2;
+
+    size_t pairwiseLen = (size_t) pairwiseCount * 4;
+    if (pos + pairwiseLen > len) {
+        return;
+    }
+    pos += pairwiseLen;
+
+    if (pos + 2 > len) {
+        return;
+    }
+    uint16_t akmCount = *(uint16_t*) (ie + pos);
+    pos += 2;


+    if (pos + 2 > len) {
+        return;
+    }
+    uint16_t pairwiseCount = *(uint16_t*) (ie + pos);
+    pos += 2 + (size_t) pairwiseCount * 4;
+
+    if (pos + 2 > len) {
+        return;
+    }
+    uint16_t akmCount = *(uint16_t*) (ie + pos);
+    pos += 2;


Fk `clang-format`

Fixes #2165

Copilot

Pull request overview

Copilot reviewed 108 out of 108 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (8)

src/common/impl/sysctl.c:1

The malloc(*resultLength) NULL-check was removed. If allocation fails, sysctl() will be called with a NULL buffer and can crash. Restore an explicit if (!data) return NULL; (or equivalent error path) before calling sysctl().
src/detection/de/de_linux.c:1
ffDBusGetString() returns a boolean success value; this condition treats success as failure and will incorrectly return an error while also leaving result populated. Flip the condition to fail only when ffDBusGetString(...) returns false.
src/detection/media/media_windows.cpp:1
getMedia() returns NULL on success, but ffStrbufAppendS(&media->error, error) is still called unconditionally. If ffStrbufAppendS doesn't accept NULL (common for string append APIs), this can crash. Guard the append (if (error) ...) or change getMedia() to return an empty string on success.
src/common/impl/settings.c:1
This function assigns raw char* pointers from the E_Config* parsed object into ffEnlightenmentSettings, but parsed is never freed and ownership/lifetime are unclear. This risks either a leak (current behavior) or a future use-after-free if parsed is ever freed. Consider copying these strings into caller-owned buffers (e.g., FFstrbuf) or documenting/adding a matching destroy/free API for ffEnlightenmentSettings that frees the underlying EET-allocated data.
src/common/impl/settings.c:1
This function assigns raw char* pointers from the E_Config* parsed object into ffEnlightenmentSettings, but parsed is never freed and ownership/lifetime are unclear. This risks either a leak (current behavior) or a future use-after-free if parsed is ever freed. Consider copying these strings into caller-owned buffers (e.g., FFstrbuf) or documenting/adding a matching destroy/free API for ffEnlightenmentSettings that frees the underlying EET-allocated data.
src/detection/displayserver/linux/wayland/wayland.h:1
Defining a global min symbol in a public header is prone to name collisions (macros from other headers, C++ std::min, etc.). Rename this helper to a project-scoped name (e.g., ffMinU32) or use an existing project macro/util if available.
src/detection/media/media_windows.cpp:1
This waits for WinRT async completion via a polling loop with ffTimeSleep(0), which can still cause unnecessary CPU wakeups/spin depending on scheduler behavior and how often get_Status is polled. Prefer an event-based wait (where possible) or add a small backoff (e.g., sleep a few ms) to reduce CPU usage while waiting.
src/detection/media/media_windows.cpp:1
This waits for WinRT async completion via a polling loop with ffTimeSleep(0), which can still cause unnecessary CPU wakeups/spin depending on scheduler behavior and how often get_Status is polled. Prefer an event-based wait (where possible) or add a small backoff (e.g., sleep a few ms) to reduce CPU usage while waiting.

CarterLi and others added 30 commits April 26, 2026 16:00

Dep (3rdparty): upgrades display-library

6979b1e

Netif (Windows): correctly selects lowest-metric default route on IPv4

ba7e1eb

... and improve performance slightly

Binary: skips short string entirely to improve performance

0db820a

Co-authored-by: Copilot <copilot@github.com>

CommandOption: generates JSON result entry even for unknown modules

039fa1b

Co-authored-by: Copilot <copilot@github.com>

JsonConfig: fixes CPUUsage preparation never executed

c10027f

Co-authored-by: Copilot <copilot@github.com>

DBus: improves message handling

37ee193

FFlist: add __restrict

ffc38eb

Platform (OpenBSD): silences a compiler warning

08b79ff

Co-authored-by: Copilot <copilot@github.com>

Platform (Windows): adds comments

4eebc1b

Co-authored-by: Copilot <copilot@github.com>

Platform: initializes pageSize

3883047

Noop, because the whole platform is statically initialized Co-authored-by: Copilot <copilot@github.com>

FFstrbuf: improves robustness of ffStrbufMatchSeparatedNS

d79e1d7

Co-authored-by: Copilot <copilot@github.com>

Font: improves pt handling

31c7354

Co-authored-by: Copilot <copilot@github.com>

Format: fixes UINT64 handling

c4c934d

Co-authored-by: Copilot <copilot@github.com>

Init: don't print unecessary ANSI escape codes

181b775

Co-authored-by: Copilot <copilot@github.com>

Library: improves code quality

e1dffe7

Co-authored-by: Copilot <copilot@github.com>

Netif: improves code quality

414f7ce

Co-authored-by: Copilot <copilot@github.com>

IO: improves code quality & reliablity

4ee7dd7

Chore: fixes typo from FF_UNITIALIZED to FF_UNINITIALIZED (#2290)

94ceeb4

Co-authored-by: or sim <you@example.com>

Netif: fixes compiler warnings

594c734

Chore: runs clang-format

55e4896

Bluetooth (Windows): uses CM API to detect BTH battery detection

e7cd5f6

Co-authored-by: Copilot <copilot@github.com>

Brightness (Windows): uses COM-less method to query WMI

6e50aaf

Co-authored-by: Copilot <copilot@github.com>

Common (Windows): removes old COM based WMI query implementation

24ec0e6

Chore: silenses compiler warnings

2e4dd1d

Brightness (Windows): cleanups debug log

69cc19d

Battery (Windows): switches to query WMI with NtApi as a fast path

025febc

Co-authored-by: Copilot <copilot@github.com>

Battery (Windows): removes option useSetupApi

d9eccd7

Networking: improves reliablity

ab5cf94

Co-authored-by: Copilot <copilot@github.com>

Option: improve reliablity

e91f62a

CarterLi and others added 15 commits May 9, 2026 15:43

Common (Windows): fixes Windows 11 detection code

87d8913

Common (Windows): works around a compiler optimise bug

bc0a515

Wallpaper (Haiku): adds support (#2314)

a923f61

* Wallpaper (Haiku): Add support * Refactor wallpaper detection logic and memory handling --------- Co-authored-by: Carter Li <CarterLi@users.noreply.github.com>

DisplayServer (Linux): updates kde-output-device-v2 again

fbc9569

DisplayServer (Linux): binds minimal version to avoid breakage

b37f020

Chore: clang-format

1c89bbc

Doc: updates changelog

f8667d9

Common (Windows): uses WinRT APIs only when FF_HAVE_WINRT is defined

60fbe1f

CI (OmniOS): fixes build

0747fc0

Terminal: fixes TDE konsole version detection

26b3a84

Fixes #2319

Doc: update PR template [ci skip]

92082ee

Logo (Builtin): adds XJ380 OS Logo (#2309)

6c7a8a8

Logo (Builtin): adds openRuyi (#2318)

50964fc

* Logo: Add openRuyi * Update ASCII art in openruyi.txt * Fix casing of 'openRuyi' in builtin.c --------- Co-authored-by: Z572 <z572@z572.online> Co-authored-by: Carter Li <CarterLi@users.noreply.github.com>

Logo (Builtin): cleans up xj380

38e98d3

Doc: update changelog [ci skip]

320e1bf

Copilot AI review requested due to automatic review settings May 11, 2026 01:57

Copilot started reviewing on behalf of CarterLi May 11, 2026 01:57 View session

Copilot AI reviewed May 11, 2026

View reviewed changes

CarterLi and others added 9 commits May 11, 2026 10:13

Common (Windows): adds a missing #include

8daec25

Logo (Builtin): cleans up Kylin

5d29e26

Logo (Builtin): tidy

43ddbdc

Fk `clang-format`

DBus: expands Get(U)Int to (u)int64

efca4f3

Media (Linux): detects song length & play position

1942dce

IO (Linux): fixes a possible fd leak

470e3b4

Chore: update .clang-format [ci skip]

235a201

DE (Linux): adds Enlightenment version detection support

8426833

WM: adds full support of Enlightenment

7799dbe

Fixes #2165

Copilot AI review requested due to automatic review settings May 12, 2026 02:57

Copilot started reviewing on behalf of CarterLi May 12, 2026 03:05 View session

Copilot AI reviewed May 12, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Release v2.63.0#2320

Release v2.63.0#2320
CarterLi wants to merge 88 commits into
masterfrom
dev

CarterLi commented May 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Conversation

CarterLi commented May 11, 2026

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants