fix: handle ftell failure before allocating input buffer in main.c#4654
Open
orbisai0security wants to merge 2 commits intofacebook:devfrom
Open
fix: handle ftell failure before allocating input buffer in main.c#4654orbisai0security wants to merge 2 commits intofacebook:devfrom
orbisai0security wants to merge 2 commits intofacebook:devfrom
Conversation
Automated security fix generated by Orbis Security AI
Author
|
Thanks for the feedback. I’ve updated the PR to narrow the scope and avoid overstating the impact. The change is now framed as defensive hardening for the The intent is simply to make the example code more robust around unexpected file-size/error cases, with no behaviour change for normal inputs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves error handling in
contrib/externalSequenceProducer/main.cwhen determining the input file size.The code uses
ftell()to determine the file size and then allocatessrcSize + 1bytes for the input buffer. Sinceftell()can fail and return-1, this patch checks the result before converting it tosize_tand using it in an allocation expression.Motivation
This makes the contrib example more robust against unexpected
ftell()failures and avoids relying on a converted sentinel value during allocation-size calculation.Security impact
This is best treated as defensive hardening/robustness improvement, not as a proven vulnerability in the core zstd library. The affected code is limited to a contrib example utility.
Testing
The existing example behaviour is unchanged for normal input files. Error paths now fail earlier if the file size cannot be determined safely.