fix(eclcompress): add flow include paths to default files to compress#862
Open
fix(eclcompress): add flow include paths to default files to compress#862
Conversation
There was a problem hiding this comment.
Pull request overview
Updates eclcompress’s default wildcard list so that it also compresses include files located under flow/include/..., matching the directory layout referenced in Issue #861.
Changes:
- Added
flow/include/{grid,regions,props}/*toDEFAULT_FILES_TO_COMPRESS. - Automatically extends the CLI help epilog’s displayed default list via the existing
EPILOGjoin ofDEFAULT_FILES_TO_COMPRESS.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #862 +/- ##
=======================================
Coverage 84.51% 84.51%
=======================================
Files 49 49
Lines 7349 7349
=======================================
Hits 6211 6211
Misses 1138 1138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rnyb
force-pushed
the
eclcompress
branch
3 times, most recently
from
903501e to
872460c
Compare
alifbe
approved these changes
May 8, 2026
| @@ -473,14 +475,22 @@ def test_utf8(tmp_path, monkeypatch): | |||
| def fixture_eclincludes(tmp_path, monkeypatch): | |||
Collaborator
There was a problem hiding this comment.
Consider renaming it something more generic since it's not only eclipse anymore
Collaborator
Author
There was a problem hiding this comment.
What about fixture_include_files?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #861