docs: fix SOCKS proxy dependency typo#1072
Open
Rohan5commit wants to merge 1 commit intoencode:masterfrom
Open
docs: fix SOCKS proxy dependency typo#1072Rohan5commit wants to merge 1 commit intoencode:masterfrom
Rohan5commit wants to merge 1 commit intoencode:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a typo in the SOCKS proxy documentation to use the correct spelling for “dependency”.
Changes:
- Corrected “dependancy” → “dependency” in the SOCKS proxy setup instructions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Make sure to install the optional dependancy using `pip install 'httpcore[socks]'`. | ||
| Make sure to install the optional dependency using `pip install 'httpcore[socks]'`. | ||
|
|
||
| The `SOCKSProxy` class should be using instead of a standard connection pool: |
There was a problem hiding this comment.
The sentence "The SOCKSProxy class should be using instead..." is grammatically incorrect; consider changing it to "should be used" (or rephrasing) for clarity.
Suggested change
| The `SOCKSProxy` class should be using instead of a standard connection pool: | |
| The `SOCKSProxy` class should be used instead of a standard connection pool: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dependancyin the SOCKS proxy setup docsRelated issue
Guideline alignment
Validation
git diff --check