Fix exception handling in tunnel connections to prevent zombie connections#1071
Open
armorbreak001 wants to merge 1 commit intoencode:masterfrom
Open
Fix exception handling in tunnel connections to prevent zombie connections#1071armorbreak001 wants to merge 1 commit intoencode:masterfrom
armorbreak001 wants to merge 1 commit intoencode:masterfrom
Conversation
…tions When a TLS handshake or other error occurs during CONNECT tunnel setup, the underlying proxy connection was not being closed, leaving it as a zombie that could never be reused. Wrap the tunnel initialization in try/except to ensure proper cleanup on failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an exception (e.g. TLS handshake failure) occurs during CONNECT tunnel setup in
TunnelHTTPConnection/AsyncTunnelHTTPConnection, the underlying proxy connection was not being closed. This left zombie connections in the pool that could never be reused, eventually leading to pool starvation under error conditions.The fix wraps the tunnel initialization block (CONNECT request → TLS upgrade → HTTP connection creation) in a
try/exceptthat ensures the proxy connection is properly cleaned up if setup fails before_connectedis set toTrue.Applies to both sync (
httpcore/_sync/http_proxy.py) and async (httpcore/_async/http_proxy.py) implementations.Fixes #1023