Fix wrong intersection with union of dynamic()#15340
Merged
josevalim merged 1 commit intoelixir-lang:mainfrom May 4, 2026
Merged
Fix wrong intersection with union of dynamic()#15340josevalim merged 1 commit intoelixir-lang:mainfrom
josevalim merged 1 commit intoelixir-lang:mainfrom
Conversation
Member
|
@gldubc we have a similar clause in disjoint? but I assume that one is fine? |
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a nasty error on intersection which makes it drop the static part systematically when intersecting a type that has
%{dynamic: :term}(meaning it'sdynamic() or some_static). These special cases do not seem necessary to me (they are handled by the general path). The typechecking example uses matching with self (y = y) to test intersection!