fix: missing pagination#91
Merged
Merged
Conversation
field123
approved these changes
May 12, 2026
|
🎉 This PR is included in version 33.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Goal
Hierarchies.Nodes.All()and 6 sibling list endpoints, and correct a separately-broken URL onCatalogs.Releases.Allthat was already returning 404s in production.Reported by GS
What changed (auto-summarised)
fix: add missing limit and offset— Seven list endpoints now serialisethis.limit/this.offsetinto the request URL viabuildURL(...), matching the existing pattern onGetNodeChildren. Methods touched:Hierarchies.Nodes.AllShopperCatalog.Hierarchies.AllShopperCatalog.Hierarchies.GetHierarchyChildrenShopperCatalog.Hierarchies.GetHierarchyNodesCatalogs.Nodes.AllCatalogs.Releases.AllCatalogs.GetCatalogReleases// TODO: API - currently not working!comments aboveHierarchies.Nodes.All(source + d.ts).test/unit/fornodes,catalog, andcatalogsasserting the SDK emitspage[limit]/page[offset]query params when.Limit()/.Offset()are chained.test/tests.tsupdated to register them.feat: correct all releases URL—Catalogs.Releases.Allwas buildingcatalogs/releases/{catalogId}(a non-existent route per the catalog-view OpenAPI spec). Corrected tocatalogs/{catalogId}/{this.endpoint}, which matches both the spec and the siblingReleases.Get/GetCatalogReleasesURL shapes.Catalogs.Releases.AllandCatalogs.GetCatalogReleasesafter cross-referencing the catalog-view spec: theGET /pcm/catalogs/{catalog_id}/releasesendpoint doesn't declarepage[limit]/page[offset]and is implicitly capped at "current release + 2 prior", so passing them was a no-op. Test assertions updated to URL-shape regressions instead.