Skip to content

chore: dd4hep-1.36#232

Open
wdconinc wants to merge 2 commits into
masterfrom
dd4hep-1.36
Open

chore: dd4hep-1.36#232
wdconinc wants to merge 2 commits into
masterfrom
dd4hep-1.36

Conversation

@wdconinc
Copy link
Copy Markdown
Contributor

@wdconinc wdconinc commented Apr 9, 2026

Briefly, what does this PR introduce?

This PR upgrades DD4hep to 1.36, https://github.com/AIDASoft/DD4hep/releases/tag/v01-36.

Copilot AI review requested due to automatic review settings April 9, 2026 14:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the container build inputs to make DD4hep v1.36 available via Spack by pulling in the upstream spack-packages change that adds the new version.

Changes:

  • Add a spack-packages cherry-pick commit for dd4hep: add v1.36
  • Document the new cherry-pick in the hash/description list

Comment thread spack-packages.sh Outdated
@wdconinc wdconinc enabled auto-merge (squash) April 9, 2026 14:53
@wdconinc wdconinc requested review from Copilot and veprbl April 9, 2026 14:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@veprbl veprbl temporarily deployed to github-pages May 7, 2026 18:12 — with GitHub Actions Inactive
@veprbl
Copy link
Copy Markdown
Member

veprbl commented May 11, 2026

Weird how this affects hit "quality" for B0TrackerHits and to a much smaller extent for TOFBarrelHits:
image
image
It must come from https://github.com/AIDASoft/DD4hep/blob/046c3a8074f951923224866a4ab2144674ccd046/DDG4/edm4hep/Geant4Output2EDM4hep.cpp#L655
The flag being unset more often, I believe is is good thing, if that is still done correctly. For the reason, it might be due to AIDASoft/DD4hep@2fafcc2

cc @DraTeots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants