Skip to content

Remove stale JNI comment in ProxyProviderLinux#2655

Open
vogella wants to merge 2 commits intoeclipse-platform:masterfrom
vogella:remove-stale-jni-comment-proxy-linux
Open

Remove stale JNI comment in ProxyProviderLinux#2655
vogella wants to merge 2 commits intoeclipse-platform:masterfrom
vogella:remove-stale-jni-comment-proxy-linux

Conversation

@vogella
Copy link
Copy Markdown
Contributor

@vogella vogella commented May 6, 2026

The static initializer of ProxyProviderLinux carries a comment claiming it loads a GSettings JNI library, but the bundle has used JNA (com.sun.jna.Native.load) since the 2021 fragment merge. The comment predates the JNA rewrite and is misleading. This removes it; no behavior change.

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

team/bundles/org.eclipse.core.net/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 2b5349c9c31a815c3ed1a2d2ee0aae96dd821df1 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Wed, 6 May 2026 16:18:41 +0000
Subject: [PATCH] Version bump(s) for 4.40 stream


diff --git a/team/bundles/org.eclipse.core.net/META-INF/MANIFEST.MF b/team/bundles/org.eclipse.core.net/META-INF/MANIFEST.MF
index 762f2613fc..3495c35847 100644
--- a/team/bundles/org.eclipse.core.net/META-INF/MANIFEST.MF
+++ b/team/bundles/org.eclipse.core.net/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %PLUGIN_NAME
 Bundle-SymbolicName: org.eclipse.core.net;singleton:=true
-Bundle-Version: 1.5.800.qualifier
+Bundle-Version: 1.5.900.qualifier
 Bundle-Activator: org.eclipse.core.internal.net.Activator
 Bundle-Vendor: %PLUGIN_PROVIDER
 Bundle-Localization: plugin
-- 
2.53.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Test Results

    54 files  ±0      54 suites  ±0   35m 38s ⏱️ -28s
 4 665 tests ±0   4 643 ✅ ±0   22 💤 ±0  0 ❌ ±0 
12 435 runs  ±0  12 279 ✅ ±0  156 💤 ±0  0 ❌ ±0 

Results for commit 0824176. ± Comparison against base commit b1b8226.

♻️ This comment has been updated with latest results.

vogella and others added 2 commits May 6, 2026 18:57
The library is loaded via JNA (com.sun.jna.Native.load), not JNI.
The comment predates the JNA rewrite and is misleading.
@vogella vogella force-pushed the remove-stale-jni-comment-proxy-linux branch from a14c69b to 0824176 Compare May 6, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants