Reduce javax E4-Injector tests to the minimum and add Singleton test#2654
Merged
HannesWell merged 1 commit intoeclipse-platform:masterfrom May 6, 2026
Merged
Conversation
Contributor
Test Results 51 files - 3 51 suites - 3 36m 15s ⏱️ +9s For more details on these errors, see this check. Results for commit 0b7d3c7. ± Comparison against base commit b1b8226. ♻️ This comment has been updated with latest results. |
HeikoKlare
approved these changes
May 6, 2026
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
This seems to be a reasonable reduction of the tests. Thank you! I only have a nit comment on an obsolete word in the readme.
HannesWell
force-pushed
the
minimize-javax-injector-tests
branch
from
8c9cd54 to
0b7d3c7
Compare
Member
Author
|
Great, thank you. The test failure is unrelated, submitting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce javax E4-Injector tests to the minimum as suggested in
I kept the separate
o.e.e4.core.javax.testsproject in order to keep dependency separation ensured.In general it should also work to move the remaining tests into
o.e.e4.core.testsbut I worry a bit that then some issues maybe could went unnoticed (although I cannot think of one explicitly).Additionally this adds a Singleton test, which didn't exist before (for jakarta and javax annotations).