Skip to content

Simplify display name in new parameterized tests for console#2651

Merged
HeikoKlare merged 1 commit intoeclipse-platform:masterfrom
trancexpress:gh2650
May 5, 2026
Merged

Simplify display name in new parameterized tests for console#2651
HeikoKlare merged 1 commit intoeclipse-platform:masterfrom
trancexpress:gh2650

Conversation

@trancexpress
Copy link
Copy Markdown
Contributor

@trancexpress trancexpress commented May 5, 2026

This change adjusts display names in new parameterized tests, for console line wrapping. This hopefully avoids confusing GitHub jobs.

In addition, emojis in IOConsoleTests are replaced with unicode codepoints.

See: #2650

@HeikoKlare
Copy link
Copy Markdown
Contributor

I just further investigated the logs and saw that it also (even more likely) be the line breaks in the test name causing the issue. I am sure if it's a good idea to have such a complex test name representation. What about assigning proper descriptive names for the parameterization than just repeating all arguments?

This change adjusts display names in new parameterized tests,
for console line wrapping. This hopefully avoids confusing GitHub jobs.

In addition, emojis in IOConsoleTests are replaced with unicode codepoints.

See: eclipse-platform#2650
@trancexpress trancexpress changed the title Replace emojis in parameterized test display name Simplify display name in new parameterized tests for console May 5, 2026
@trancexpress
Copy link
Copy Markdown
Contributor Author

Descriptive will be difficult, but distinctive is possible. How about now?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Test Results

    54 files  ±  0      54 suites  ±0   35m 35s ⏱️ -49s
 4 665 tests  - 184   4 643 ✅  - 184   22 💤 ±0  0 ❌ ±0 
12 435 runs  ±  0  12 279 ✅ ±  0  156 💤 ±0  0 ❌ ±0 

Results for commit dbe03f0. ± Comparison against base commit ca6b952.

This pull request removes 387 and adds 92 tests. Note that renamed tests count towards both.
, nl=[Ljava.lang.String;@108a2339]
, nl=[Ljava.lang.String;@10ae7263]
, nl=[Ljava.lang.String;@10d7df4e]
, nl=[Ljava.lang.String;@138eac9f]
, nl=[Ljava.lang.String;@148515e5]
, nl=[Ljava.lang.String;@1a9e195]
, nl=[Ljava.lang.String;@1e365d1a]
, nl=[Ljava.lang.String;@1ed6c08]
, nl=[Ljava.lang.String;@1f2cb69f]
, nl=[Ljava.lang.String;@23185c7f]
…
org.eclipse.debug.tests.console.ConsoleOutputLineTruncateTest ‑ test(Parameters)[10] unix_nl_10
org.eclipse.debug.tests.console.ConsoleOutputLineTruncateTest ‑ test(Parameters)[11] unix_nl_11
org.eclipse.debug.tests.console.ConsoleOutputLineTruncateTest ‑ test(Parameters)[12] unix_nl_12
org.eclipse.debug.tests.console.ConsoleOutputLineTruncateTest ‑ test(Parameters)[13] unix_nl_13
org.eclipse.debug.tests.console.ConsoleOutputLineTruncateTest ‑ test(Parameters)[14] unix_nl_14
org.eclipse.debug.tests.console.ConsoleOutputLineTruncateTest ‑ test(Parameters)[15] unix_nl_15
org.eclipse.debug.tests.console.ConsoleOutputLineTruncateTest ‑ test(Parameters)[16] unix_nl_16
org.eclipse.debug.tests.console.ConsoleOutputLineTruncateTest ‑ test(Parameters)[17] unix_nl_17
org.eclipse.debug.tests.console.ConsoleOutputLineTruncateTest ‑ test(Parameters)[18] unix_nl_18
org.eclipse.debug.tests.console.ConsoleOutputLineTruncateTest ‑ test(Parameters)[19] unix_nl_19
…

Copy link
Copy Markdown
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Descriptive will be difficult, but distinctive is possible. How about now?

Sounds good. I like the proposal, even in case it finally not fixes the issue with the test report. Let's give this a try. Thank you for quickly taking action!

@HeikoKlare HeikoKlare merged commit a877760 into eclipse-platform:master May 5, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants