Remove unused CSS serializer classes and dead color converter config#3978
Merged
vogella merged 2 commits intoeclipse-platform:masterfrom May 7, 2026
Merged
Conversation
The CSSSerializer / CSSSerializerConfiguration / CSSHTMLSerializerConfiguration trio in org.eclipse.e4.ui.css.core.serializers and CSSSWTSerializerConfiguration in org.eclipse.e4.ui.css.swt.serializers have no callers in the production tree or in any built test bundle. Their only references are in tests/.../tkuiTestsToRefactor, the quarantined refactor backlog that is not part of any test build. Drop the four classes and the matching x-friends/x-internal exports for the two serializers packages from the bundle manifests. Drop ICSSValueConverterColorConfig and CSSValueConverterConfigColorImpl in the same pass: the COLOR_HEXA_FORMAT_CONFIG / COLOR_NAME_FORMAT_CONFIG / COLOR_RGB_FORMAT_CONFIG instances those classes provide are never constructed by any caller, so the corresponding instanceof branch in CSS2ColorHelper.getColorStringValue is unreachable and the helper always returns the hex form. Simplify the helper to drop its ICSSValueConverterConfig parameter and update the two SWT color converters that called it. All bundles internal (x-friends/x-internal), no API surface affected.
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
Contributor
Author
|
A grep across eclipse.pde for any of those names or the two *.serializers package paths returns zero matches, and the PR description notes the affected packages are x-friends/x-internal with no API surface change. So this PR should not affect the eclipse.pde repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CSSSerializer / CSSSerializerConfiguration / CSSHTMLSerializerConfiguration trio in org.eclipse.e4.ui.css.core.serializers and CSSSWTSerializerConfiguration in org.eclipse.e4.ui.css.swt.serializers have no callers in the production tree or in any built test bundle. Their only references are in tests/.../tkuiTestsToRefactor, the quarantined refactor backlog that is not part of any test build. Drop the four classes and the matching x-friends/x-internal exports for the two serializers packages from the bundle manifests.
Drop ICSSValueConverterColorConfig and CSSValueConverterConfigColorImpl in the same pass: the COLOR_HEXA_FORMAT_CONFIG / COLOR_NAME_FORMAT_CONFIG / COLOR_RGB_FORMAT_CONFIG instances those classes provide are never constructed by any caller, so the corresponding instanceof branch in CSS2ColorHelper.getColorStringValue is unreachable and the helper always returns the hex form. Simplify the helper to drop its ICSSValueConverterConfig parameter and update the two SWT color converters that called it.
All bundles internal (x-friends/x-internal), no API surface affected.