Drop unreachable IOException from CSSEngine String overloads#3976
Merged
vogella merged 2 commits intoeclipse-platform:masterfrom May 7, 2026
Merged
Conversation
parseSelectors(String), parsePropertyValue(String), and parseStyleDeclaration(String) wrap the input in a StringReader and delegate to the Reader-based overload. StringReader.read() never throws IOException, but the signature of the Reader overload propagates IOException up from the SAC parser API, so the String forms used to declare a checked exception that could not actually fire. Drop throws IOException from the three String overloads on the internal CSSEngine interface and wrap the inner Reader call in AbstractCSSEngine in try/catch -> IllegalStateException to preserve the impossible case as a defensive guard. Bundle is x-friends so the signature change is internal-only.
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
Member
|
This breaks PDE compile. |
Contributor
Author
|
I have a look |
vogella
added a commit
to vogella/eclipse.pde
that referenced
this pull request
May 7, 2026
eclipse-platform/eclipse.platform.ui#3976 removed the unnecessary IOException
vogella
added a commit
to eclipse-pde/eclipse.pde
that referenced
this pull request
May 7, 2026
eclipse-platform/eclipse.platform.ui#3976 removed the unnecessary IOException
Contributor
Author
Thanks. Fixed with eclipse-pde/eclipse.pde#2327 |
Contributor
Author
|
Validated with a local aggregator build containing 8ccf90a and the PDE fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseSelectors(String), parsePropertyValue(String), and parseStyleDeclaration(String) wrap the input in a StringReader and delegate to the Reader-based overload. StringReader.read() never throws IOException, but the signature of the Reader overload propagates IOException up from the SAC parser API, so the String forms used to declare a checked exception that could not actually fire. Drop throws IOException from the three String overloads on the internal CSSEngine interface and wrap the inner Reader call in AbstractCSSEngine in try/catch -> IllegalStateException to preserve the impossible case as a defensive guard. Bundle is x-friends so the signature change is internal-only.