Remove unused BootstrapTheme3x and its dummy.css#3975
Merged
vogella merged 1 commit intoeclipse-platform:masterfrom May 7, 2026
Merged
Remove unused BootstrapTheme3x and its dummy.css#3975vogella merged 1 commit intoeclipse-platform:masterfrom
vogella merged 1 commit intoeclipse-platform:masterfrom
Conversation
Contributor
Contributor
|
I think you will have major problems with PRs not based on the current master. |
vogella
force-pushed
the
remove-bootstrap-theme-3x
branch
from
f1aa3e4 to
c5f1b6b
Compare
BootstrapTheme3x was a reflective bootstrap helper added in 2010 (bug 310153, commit 99e054c) so org.eclipse.ui.internal.Workbench could activate the e4 styling engine without taking a hard dependency on org.eclipse.e4.ui.css.swt.theme. The Workbench call site was removed in 2011 by commit ad3c59a ("Merge remote branch 'e4/master' Merge in the e4.ui stuff, plus the compat org.eclipse.ui.workbench"), the big merge that brought the e4 UI stack into the platform; styling initialization moved into the new e4-based workbench and the bridge became dead code. Nothing in the platform tree has referenced the class since, and the dummy.css it registered as the default theme is empty. Drop the class, the css/dummy.css placeholder, and the now-empty css/ entry from build.properties.
vogella
force-pushed
the
remove-bootstrap-theme-3x
branch
from
c5f1b6b to
ff1364c
Compare
merks
approved these changes
May 6, 2026
Contributor
merks
left a comment
merks
left a comment
There was a problem hiding this comment.
Off course it looks fine. 😀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BootstrapTheme3xwas a reflective bootstrap helper added in 2010 (bug 310153, commit 99e054c) soorg.eclipse.ui.internal.Workbenchcould activate the e4 styling engine without taking a hard dependency onorg.eclipse.e4.ui.css.swt.theme. The Workbench call site was removed in 2011 by commit ad3c59a (the big "Merge in the e4.ui stuff" merge that brought the e4 UI stack into the platform), when styling initialization moved into the e4-based workbench. Nothing in the platform tree has referenced the class since, and thedummy.cssit registered as the default theme is empty. This drops the class, the placeholder CSS, the now-emptycss/entry frombuild.properties, and bumps the bundle micro version.