Fix sticky scroll height calculation for variable line heights#3971
Open
Christopher-Hermann wants to merge 1 commit intoeclipse-platform:masterfrom
Open
Fix sticky scroll height calculation for variable line heights#3971Christopher-Hermann wants to merge 1 commit intoeclipse-platform:masterfrom
Christopher-Hermann wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
Contributor
Member
|
There is a test failure in |
409f8b3 to
f731e13
Compare
When emoji or other content affects line heights, sticky scroll was calculating the total height wrong by assuming all lines were the same. Now it gets the actual height for each line instead. Also fixes the height check for limiting visible lines.
f731e13 to
2e83544
Compare
Contributor
Author
Fixed in the latest version 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
StickyScrollingControlwas computing the sticky area height by multiplying a single line height by the number of sticky lines. This assumption breaks when content like emoji causes individual lines to render taller than the default — the canvas ends up too short, clipping the sticky lines visually.calculateCanvasBoundsnow sums the actual height of each sticky line usinggetLineHeight(offset)instead of using a uniformgetLineHeight().Reproduce:
Create an XML file with the content below. Enable sticky scrolling and scroll a few lines:
Follow up of #3748