Fix the handling of subscriptions with multiple topics and extra fields#2425
Conversation
f26bbaf to
01fd8d8
Compare
|
@abalarev will you also provide a system-test which tests this fix - seems important enough to me to cover it with an integration-test |
|
@thjaeckle Sounds reasonable, I'll add some system test(s) |
|
@abalarev thanks for the added system tests 👍 |
|
@thjaeckle Please run the system tests again, I've pushed a fix. |
01fd8d8 to
340ea56
Compare
thjaeckle
left a comment
There was a problem hiding this comment.
Thanks for tackling this — the refactor direction looks right and the headline scenarios are well-covered. A few correctness concerns and polish items inline.
One overarching note on test coverage: the four correctness concerns flagged below (shared-root trimming, cross-streaming-type early return, non-deterministic findFirst over a Set, and catch-all / extras precedence) are not yet exercised by the new tests. Once the intended behavior for each is settled, please add regression tests that lock it in.
Signed-off-by: Andrey Balarev <andrey.balarev@bosch.com>
b6b2921 to
a2c6d48
Compare
|
@thjaeckle Thank you for the review findings and comments! |
|
@abalarev one thread is still unresolved - the other changes look good 👍 |
Signed-off-by: Andrey Balarev <andrey.balarev@bosch.com>
a2c6d48 to
f0ccc9d
Compare
Summary
Resolves incorrect handling of subscriptions for multiple topics, containing at least one extra field.
Issue
What's changed
OutboundMaooingProcessorActor flow changed as follows:
Added system tests: eclipse-ditto/ditto-testing#33