Skip to content

Easy collection#239

Open
rozyczko wants to merge 5 commits intodevelopfrom
easy_collection
Open

Easy collection#239
rozyczko wants to merge 5 commits intodevelopfrom
easy_collection

Conversation

@rozyczko
Copy link
Copy Markdown
Member

@rozyczko rozyczko commented Apr 29, 2026

This is the collection list as described in #226
Rebased against the new develop branch and due to the change of the base class, made a separate PR.

For discussion look in: #226

@rozyczko rozyczko added [scope] enhancement Adds/improves features (major.MINOR.patch) [priority] high Should be prioritized soon [area] base classes Changes to or creation of new base classes labels Apr 29, 2026
Copy link
Copy Markdown
Member

@henrikjacobsenfys henrikjacobsenfys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the global object well enough to comment on that aspect, but this looks good to me, with two exceptions

Comment thread src/easyscience/base_classes/easy_collection.py
Comment thread src/easyscience/base_classes/easy_collection.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

❌ Patch coverage is 87.61468% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.67%. Comparing base (4be7c47) to head (c436640).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/easyscience/base_classes/easy_collection.py 87.50% 27 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #239      +/-   ##
===========================================
+ Coverage    86.63%   86.67%   +0.04%     
===========================================
  Files           55       56       +1     
  Lines         4690     4907     +217     
===========================================
+ Hits          4063     4253     +190     
- Misses         627      654      +27     
Flag Coverage Δ
integration 44.67% <22.01%> (-1.07%) ⬇️
unittests 85.38% <87.61%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/easyscience/base_classes/__init__.py 100.00% <100.00%> (ø)
src/easyscience/base_classes/easy_collection.py 87.50% <87.50%> (ø)

@rozyczko rozyczko marked this pull request as ready for review May 1, 2026 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[area] base classes Changes to or creation of new base classes [priority] high Should be prioritized soon [scope] enhancement Adds/improves features (major.MINOR.patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants