Skip to content

Coordinator: convert join_group to async def#2955

Merged
dpkp merged 13 commits intomasterfrom
dpkp/join-group-async
May 7, 2026
Merged

Coordinator: convert join_group to async def#2955
dpkp merged 13 commits intomasterfrom
dpkp/join-group-async

Conversation

@dpkp
Copy link
Copy Markdown
Owner

@dpkp dpkp commented May 7, 2026

    1. Add _process_join_group_response(response) and _process_sync_group_response(response) -> bytes (raise-or-return). Test against existing parametrized response cases.
    1. Add _on_join_prepare_async / _on_join_complete_async in base; override in ConsumerCoordinator.
    1. Add _do_join_and_sync_async. MockBroker test: script JoinGroup → SyncGroup, assert returned bytes; one test per error code, assert correct exception type.
    1. Add join_group_async and ensure_active_group_async.
    1. Replace join_group and ensure_active_group bodies with manager.run(...) facades.
    1. Delete dead code
  • AsyncConsumerRebalanceListener
  • fixup
    1. Wrap listener call site with a time.monotonic() measurement and log.warning if it exceeds slow_task_threshold_secs
    1. few more tests
  • Drop unused join_group()

@dpkp dpkp merged commit f9b7119 into master May 7, 2026
19 checks passed
@dpkp dpkp deleted the dpkp/join-group-async branch May 7, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant