Coordinator: convert join_group to async def#2955
Merged
Conversation
Owner
dpkp
commented
May 7, 2026
-
- Add _process_join_group_response(response) and _process_sync_group_response(response) -> bytes (raise-or-return). Test against existing parametrized response cases.
-
- Add _on_join_prepare_async / _on_join_complete_async in base; override in ConsumerCoordinator.
-
- Add _do_join_and_sync_async. MockBroker test: script JoinGroup → SyncGroup, assert returned bytes; one test per error code, assert correct exception type.
-
- Add join_group_async and ensure_active_group_async.
-
- Replace join_group and ensure_active_group bodies with manager.run(...) facades.
-
- Delete dead code
- AsyncConsumerRebalanceListener
- fixup
-
- Wrap listener call site with a time.monotonic() measurement and log.warning if it exceeds slow_task_threshold_secs
-
- few more tests
- Drop unused join_group()
…_response(response) -> bytes (raise-or-return). Test against existing parametrized response cases.
…ride in ConsumerCoordinator.
…yncGroup, assert returned bytes; one test per error code, assert correct exception type.
…g.warning if it exceeds slow_task_threshold_secs
…out; add regression test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.