Improve SseParser class comment#129167
Open
mrek-msft wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates XML documentation summaries for the Server-Sent Events parser types.
Changes:
- Refines
SseParser’s type summary to mention parsing SSEs “read from a trustworthy stream”. - Refines
SseParser<T>’s type summary similarly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/libraries/System.Net.ServerSentEvents/src/System/Net/ServerSentEvents/SseParser.cs | Updates the static factory type’s XML summary text. |
| src/libraries/System.Net.ServerSentEvents/src/System/Net/ServerSentEvents/SseParser_1.cs | Updates the generic parser type’s XML summary text. |
| namespace System.Net.ServerSentEvents | ||
| { | ||
| /// <summary>Provides a parser for parsing server-sent events.</summary> | ||
| /// <summary>Provides a parser for parsing server-sent events read from a trustworthy stream.</summary> |
| namespace System.Net.ServerSentEvents | ||
| { | ||
| /// <summary>Provides a parser for server-sent events information.</summary> | ||
| /// <summary>Provides a parser for server-sent events information read from a trustworthy stream</summary> |
Member
|
I think we should consider enabling the scenario instead, filed #129168 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.