Disable failing tests on mono#129163
Open
BrzVlad wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables a small set of failing System.Text.Json tests on Mono by annotating them with [ActiveIssue] skips tied to tracked GitHub issues, targeting Apple mobile platforms.
Changes:
- Add an
[ActiveIssue]skip toMetadataServices_NullPolymorphismOptions_DoesNotActivateAttributeClassifier. - Add
[ActiveIssue]skips to two JSONL async-enumerable “partial item failure” tests (Stream + PipeWriter variants).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/PolymorphicTests.TypeClassifier.cs |
Skips a failing polymorphism metadata ordering/behavior test on Mono Apple mobile via [ActiveIssue]. |
src/libraries/System.Text.Json/tests/Common/AsyncEnumerableTests.cs |
Skips two failing async-enumerable JSONL partial-failure tests on Mono Apple mobile via [ActiveIssue]. |
The polymorphic classifier and async-enumerable partial-failure issues are Mono full-AOT behaviors shared across all Apple mobile targets, so group the ActiveIssue platform filter as Apple mobile rather than iOS/tvOS only. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace the explicit iOS/tvOS/MacCatalyst platform list with the PlatformDetection.IsAppleMobile condition, combined with IsMonoRuntime to keep the skip scoped to Mono (so CoreCLR-on-Apple-mobile coverage is unaffected). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#128766
#128765