Conversation
…sion directly Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/dc5a1bed-f1d4-45ec-9530-72467d1d4bda Co-authored-by: maraf <10020471+maraf@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove public WasmWebcilVersion property from MSBuild
Remove public Apr 24, 2026
WasmWebcilVersion MSBuild property; always use internal _WasmWebcilVersion
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
WasmWebcilVersion MSBuild property; always use internal _WasmWebcilVersionWasmWebcilVersion MSBuild property; always use internal _WasmWebcilVersion
lewing
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WasmWebcilVersionwas a public MSBuild property that could be set externally, but the webcil version should always be determined internally (1for CoreCLR,0otherwise). Remove the line that copies the public property into the private one, making_WasmWebcilVersionself-contained.Changes
Microsoft.NET.Sdk.WebAssembly.Browser.targets: Remove the assignment<_WasmWebcilVersion>$(WasmWebcilVersion)</_WasmWebcilVersion>(line 206). The two default-value lines remain unchanged:All other usages in the file (
ConvertDllsToWebciltask attributes) already reference$(_WasmWebcilVersion)and are unaffected.Original prompt
This pull request was created from Copilot chat.