Skip to content

Drop daily quality from release/10.0 and 10.0 channels#5219

Open
LoopedBard3 wants to merge 1 commit into
dotnet:mainfrom
LoopedBard3:loopedbard3/net10-daily-sdk-fix
Open

Drop daily quality from release/10.0 and 10.0 channels#5219
LoopedBard3 wants to merge 1 commit into
dotnet:mainfrom
LoopedBard3:loopedbard3/net10-daily-sdk-fix

Conversation

@LoopedBard3
Copy link
Copy Markdown
Member

After .NET 10 GA, -Quality daily on the release/10.0 (and bare 10.0) channels resolves to internal-only servicing SDK builds (e.g. SDK 10.0.9-flavored bits) whose matching Microsoft.NETCore.App.Runtime.<rid> runtime pack has not yet shipped publicly on the dotnet10 / dotnet-public NuGet feeds.

That breaks the CertHelper --self-contained publish in run_performance_job.py:

performance\src\tools\CertHelper\CertHelper.csproj : error NU1102:
  Unable to find package Microsoft.NETCore.App.Runtime.win-x64
  with version (= 10.0.9)

(Example failing run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2969704)

Fix

Remove 'quality': 'daily' from the release/10.0 and 10.0 entries in channel_map.py. With no quality specified, dotnet.py omits the -Quality flag (it already handles None correctly), so dotnet-install hits the public aka.ms/dotnet/10.0/ GA endpoint — currently SDK 10.0.203 / runtime 10.0.7 — whose runtime packs are publicly available, so the publish step succeeds and the SDK rolls forward automatically with each public servicing release.

What's unchanged

  • main (net11) stays on quality: daily — net11 is pre-release and its dailies are public, so that's still the right choice.
  • nativeaot10.0 is unchanged in this PR but has the same shape (branch: 10.0, quality: daily) and would hit the same NU1102 if exercised today. Happy to fold it in if reviewers prefer; left out for now since it's not the failing path.
  • No changes to sdk-perf-jobs.yml; this is purely a fix for runs that already use release/10.0 / 10.0.

Trade-off

The net10 leg now baselines against the latest publicly-released servicing build (e.g. runtime 10.0.7) instead of the freshest internal daily. For BDN regression work this is actually the more reproducible baseline; runtime perf jobs that build their own Core_Root use the SDK only as build-time tooling, so a slightly older public SDK is fine.

Validation

Verified manually by triggering perf runs from this branch against release/10.0 and confirming the CertHelper publish succeeds and the runs upload results end-to-end.

Copilot AI review requested due to automatic review settings May 11, 2026 20:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the runtime channel configuration used by the repo’s tooling so that .NET 10 jobs no longer request internal-only “daily” servicing SDK builds after .NET 10 GA, avoiding restore/publish failures (e.g., missing runtime packs on public feeds).

Changes:

  • Removed quality: 'daily' from the 10.0 channel entry.
  • Removed quality: 'daily' from the release/10.0 channel entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LoopedBard3 LoopedBard3 self-assigned this May 11, 2026
After .NET 10 GA, `-Quality daily` for these channels resolves to
internal-only servicing SDK builds (e.g. 10.0.9) whose matching
`Microsoft.NETCore.App.Runtime.<rid>` runtime pack has not yet
shipped publicly on the dotnet10 / dotnet-public NuGet feeds.

That breaks the CertHelper `--self-contained` publish in
run_performance_job.py with NU1102. With no quality specified,
dotnet-install hits the public `aka.ms/dotnet/10.0/` GA endpoint
(currently SDK 10.0.203 / runtime 10.0.7), whose runtime packs are
publicly available, so the publish step succeeds.

main (net11) and nativeaot* channels are unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@LoopedBard3 LoopedBard3 force-pushed the loopedbard3/net10-daily-sdk-fix branch from 740b22c to 425e5c9 Compare May 11, 2026 20:29
@LoopedBard3 LoopedBard3 marked this pull request as ready for review May 11, 2026 20:29
Copilot AI review requested due to automatic review settings May 11, 2026 20:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants