[automated] Merge branch 'main' => 'feature/net11-scouting'#19633
Open
github-actions[bot] wants to merge 26 commits intofeature/net11-scoutingfrom
Open
[automated] Merge branch 'main' => 'feature/net11-scouting'#19633github-actions[bot] wants to merge 26 commits intofeature/net11-scoutingfrom
github-actions[bot] wants to merge 26 commits intofeature/net11-scoutingfrom
Conversation
… Build ID 2923304 (#19418) * Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 2923162 * Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 2923162 --------- Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Tomas Grosup <Tomas.Grosup@gmail.com>
…rompting (#19624) * Initial plan * Fix aw-auto-update: add network access for Go/GitHub and improve prompting - Add `go` and `github` ecosystems to network.allowed to unblock Go module proxy and GitHub release asset downloads (root cause of engine crash - 618 blocked firewall requests) - Improve prompt: explicit no-op fast exit, forbid manual dependency resolution, fail-fast on upgrade/compile errors - Recompile lock file with gh-aw v0.68.3 Agent-Logs-Url: https://github.com/dotnet/fsharp/sessions/5e1f098d-93ec-405f-af40-876e201dd8b2 Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
* Backflow from https://github.com/dotnet/dotnet / b61c1c3 build 310568 [[ commit created by automation ]] * Update dependencies from build 310568 No dependency updates to commit [[ commit created by automation ]] * Fix CI: restore MSBuild NuGet feed removed by codeflow The codeflow automation incorrectly removed the darc-pub-DotNet-msbuild-Trusted-e5ebe15 NuGet feed from NuGet.config, even though MSBuild 18.6.1 packages still depend on it. The VMR source at the same SHA retains this feed. Restoring it fixes all NU1103 errors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix flaky FindReferences test by isolating checker instance The ProjectActivePatternInSig test was using the shared global checker, which causes race conditions when tests run in parallel. Give it a dedicated FSharpChecker instance, matching the pattern used by Project25. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Backflow from https://github.com/dotnet/dotnet / ab01524 build 310648 [[ commit created by automation ]] * Update dependencies from build 310648 No dependency updates to commit [[ commit created by automation ]] * Fix CI: restore MSBuild NuGet feed removed by codeflow The codeflow update removed the darc-pub-DotNet-msbuild-Trusted-e5ebe15 NuGet feed from NuGet.config, but the Microsoft.Build 18.6.1 packages (from SHA e5ebe15) still depend on it, causing NU1103 errors across all CI builds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…0421.10 (#19627) On relative base path root Microsoft.Build , Microsoft.Build.Framework , Microsoft.Build.Tasks.Core , Microsoft.Build.Utilities.Core From Version 18.6.1 -> To Version 18.6.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…421.8 (#19628) On relative base path root Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.7.0-1.26220.12 -> To Version 5.7.0-1.26221.8 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Chore: Eliminate debug/release IL baseline duality - Add <Optimize>true</Optimize> to FSharp.Core.fsproj so Debug and Release FSharp.Core produce equivalent IL, eliminating the root cause of debug/release baseline differences in EmittedIL tests. - Remove debug/release config branching from Compiler.fs IL baseline resolution (baselineIsDebug, configTag, TEST_BASELINE_CONFIG). - Consolidate 151 .release.bsl files into generic .bsl files. - Delete 176 .debug.bsl files that are now redundant. - Unify #if Release/#else IL forks in Inlining.fs and StaticsInInterfaces.fs test files (FSharp.Core inlining now identical in both configs). - Revert WindowsDebugBaselines CI job from azure-pipelines-PR.yml. - SurfaceArea baselines intentionally kept separate (MethodHandleOf is public in Debug, internal in Release via #if DEBUG in FSharp.Core). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Improve Optimize comment with debugging instructions Address review feedback by adding a note on how to disable optimization for local FSharp.Core debugging (dotnet build -p:Optimize=false). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Adam Boniecki <20281641+abonie@users.noreply.github.com>
- AsyncType.CreateTask: increase waitASec timeout from 1s to 30s (thread pool saturation on loaded CI prevents scheduling trivial tasks) - Tasks/TasksDynamic testNonBlocking: replace Thread.Sleep(100) race with ManualResetEventSlim gate for deterministic synchronization - Tasks/TasksDynamic testExceptionThrownInFinally: wire up the already-declared-but-unused stepOutside SemaphoreSlim instead of Thread.Sleep(100) race (matching test2ndExceptionThrownInFinally pattern) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/roslyn build 20260422.9 On relative base path root Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.7.0-1.26221.8 -> To Version 5.7.0-1.26222.9 * Update dependencies from https://github.com/dotnet/roslyn build 20260423.6 On relative base path root Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.7.0-1.26221.8 -> To Version 5.7.0-1.26223.6 * Update dependencies from https://github.com/dotnet/roslyn build 20260424.4 On relative base path root Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.7.0-1.26221.8 -> To Version 5.7.0-1.26224.4 * Update dependencies from https://github.com/dotnet/roslyn build 20260425.2 On relative base path root Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.7.0-1.26221.8 -> To Version 5.7.0-1.26225.2 * Update dependencies from https://github.com/dotnet/roslyn build 20260426.5 On relative base path root Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.7.0-1.26221.8 -> To Version 5.7.0-1.26226.5 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…422.2 (#19635) On relative base path root Microsoft.DotNet.Arcade.Sdk From Version 10.0.0-beta.26220.5 -> To Version 10.0.0-beta.26222.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…19643) * IlxGen: fix missing CompilationMapping attribute for generic values * Release notes * Update baselines
…methods (#19503) The IgnoreOverrides filter in InfoReader.FilterOverrides incorrectly removed abstract override methods (e.g. C# 'abstract override string ToString()') because they were signature-equivalent to the base virtual method. This caused GetClassDispatchSlots to miss these as required dispatch slots. The fix adds an isAbstract check to the FilterOverrides function so that abstract methods from derived types are preserved even when they override an equivalent virtual in a supertype. This ensures the compiler correctly reports FS0365 when a non-abstract F# class inherits from a C# class with abstract override members without providing implementations. Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
46f4147 to
64834ed
Compare
Guard disposeOriginal() against accessing a faulted Lazy<T> in EnumerateTryWith. When source.GetEnumerator() throws, the Lazy caches the exception and re-throws on every .Value access, causing the disposal path to re-trigger moveExceptionHandler. Add IsValueCreated check so disposal is skipped when no enumerator was successfully created. Fixes #19660 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
approved these changes
Apr 30, 2026
* Update dependencies from https://github.com/dotnet/roslyn build 20260427.8 On relative base path root Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.7.0-1.26226.5 -> To Version 5.7.0-1.26227.8 * Retrigger CI after infra flake (Node.js SIGABRT in SDK install) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/roslyn build 20260428.16 On relative base path root Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.7.0-1.26226.5 -> To Version 5.8.0-1.26228.16 * Update dependencies from https://github.com/dotnet/roslyn build 20260429.9 On relative base path root Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.7.0-1.26226.5 -> To Version 5.8.0-1.26229.9 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…0429.2 (#19666) On relative base path root Microsoft.Build , Microsoft.Build.Framework , Microsoft.Build.Tasks.Core , Microsoft.Build.Utilities.Core From Version 18.6.3 -> To Version 18.6.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/roslyn build 20260430.5 On relative base path root Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.8.0-1.26229.9 -> To Version 5.8.0-1.26230.5 * Update dependencies from https://github.com/dotnet/roslyn build 20260501.7 On relative base path root Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.8.0-1.26229.9 -> To Version 5.8.0-1.26251.7 * Update dependencies from https://github.com/dotnet/roslyn build 20260502.1 On relative base path root Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.8.0-1.26229.9 -> To Version 5.8.0-1.26252.1 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
….3 (#19669) --- updated-dependencies: - dependency-name: OpenTelemetry.Exporter.OpenTelemetryProtocol dependency-version: 1.15.3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…/net11-scouting # Conflicts: # eng/Version.Details.props # eng/Version.Details.xml # global.json
64834ed to
0b96de0
Compare
…lict The merge from main into feature/net11-scouting produced duplicate PackageReference and </ItemGroup> tags. This resolves the MSB4025 error by using main's version of the PackageReference block. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I detected changes in the main branch which have not been merged yet to feature/net11-scouting. I'm a robot and am configured to help you automatically keep feature/net11-scouting up to date, so I've opened this PR.
This PR merges commits made on main by the following committers:
Instructions for merging from UI
This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.
If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.
Instructions for merging via command line
Run these commands to merge this pull request from the command line.
or if you are using SSH
After PR checks are complete push the branch
Instructions for resolving conflicts
Instructions for updating this pull request
Contributors to this repo have permission update this pull request by pushing to the branch 'merge/main-to-feature/net11-scouting'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
The provided examples assume that the remote is named 'origin'. If you have a different remote name, please replace 'origin' with the name of your remote.
or if you are using SSH
Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.