Skip to content

Skip validation when extracting config variables#13831

Open
scarab-systems wants to merge 2 commits into
docker:mainfrom
scarab-systems:13613-config-variable-validation
Open

Skip validation when extracting config variables#13831
scarab-systems wants to merge 2 commits into
docker:mainfrom
scarab-systems:13613-config-variable-validation

Conversation

@scarab-systems

@scarab-systems scarab-systems commented Jun 9, 2026

Copy link
Copy Markdown

What I did

  • Allow unresolved Compose models used for variable discovery to skip validation while interpolation expressions are still present.
  • Apply the same behavior to config --variables and remote-stack interpolation-variable prompting.
  • Add regression coverage for templated typed port fields such as host_ip and published.

Related issue

Fixes #13613

(not mandatory) A picture of a cute animal, if possible in relation to what you did
![cute fuzzy animal]
hortonhearsawho

Validation

  • go test ./cmd/compose
  • docker buildx bake lint

Signed-off-by: bigmomma <scarab.systems@yahoo.com>
@scarab-systems scarab-systems requested a review from a team as a code owner June 9, 2026 01:30
@scarab-systems scarab-systems requested review from glours and ndeloof June 9, 2026 01:30
@glours

glours commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

/review

@docker-agent

docker-agent Bot commented Jun 9, 2026

Copy link
Copy Markdown

PR Review Failed — The review agent encountered an error and could not complete the review. View logs.

@glours glours left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks correct, but I’d like us to add a regression test covering the up path as well.

The issue originally affects the remote-stack prompt flow used by up, so having coverage there would help ensure this does not regress again.

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@scarab-systems

scarab-systems commented Jun 9, 2026

Copy link
Copy Markdown
Author

Thanks for the review. That makes sense, and I appreciate the context on the up remote-stack prompt flow. I’ll add a focused regression test for that path.

Signed-off-by: bigmomma <scarab.systems@yahoo.com>
@scarab-systems

Copy link
Copy Markdown
Author

Added the focused up regression test in the latest commit. I also verified it locally with go test ./cmd/compose -count=1 and make lint.

@scarab-systems scarab-systems requested a review from glours June 9, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] cannot customize oci:// app compose.yaml as variable interpolation fails

2 participants