Graduate lockfile from experimental to stable#1212
Open
brooke-hamilton wants to merge 5 commits intodevcontainers:mainfrom
Open
Graduate lockfile from experimental to stable#1212brooke-hamilton wants to merge 5 commits intodevcontainers:mainfrom
brooke-hamilton wants to merge 5 commits intodevcontainers:mainfrom
Conversation
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
chrmarti
requested changes
May 4, 2026
Contributor
chrmarti
left a comment
chrmarti
left a comment
There was a problem hiding this comment.
Great, thanks! Really just one question: The two experimental properties are no longer needed in code, it seems?
| @@ -195,6 +195,8 @@ export interface ContainerFeatureInternalParams { | |||
| platform: NodeJS.Platform; | |||
| experimentalLockfile?: boolean; | |||
Contributor
There was a problem hiding this comment.
Are the two experimental properties still needed?
| const newLockfileContentString = JSON.stringify(lockfile, null, 2) + '\n'; | ||
| const newLockfileContent = Buffer.from(newLockfileContentString); | ||
| if (params.experimentalFrozenLockfile && !oldLockfileContent) { | ||
| if ((params.frozenLockfile || params.experimentalFrozenLockfile) && !oldLockfileContent) { |
Contributor
There was a problem hiding this comment.
I think the experimental flag is already folded into the new property?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request graduates the lockfile feature from experimental to stable. Lockfiles are now generated by default during
buildandupcommands to ensure reproducible builds. New CLI flags (--no-lockfileand--frozen-lockfile) are introduced for more explicit control, while the old experimental flags are deprecated but still accepted with warnings.Lockfile Feature Graduation and CLI Changes:
.devcontainer-lock.json) are now generated by default onbuildandup, pinning feature versions for reproducibility. [1] [2]--no-lockfile(disables lockfile generation/verification) and--frozen-lockfile(enforces lockfile existence and immutability). Deprecated--experimental-lockfileand--experimental-frozen-lockfilewith warnings. [1] [2] [3] [4] [5] [6]Documentation and Tooling:
README.mdandCHANGELOG.mdto reflect lockfile graduation and new CLI behavior. [1] [2]docs/contributing-code.mdto clarify packaging requirements before running tests.This PR closes issue #1195
There are no spec changes in this PR, but there is a related proposal at devcontainers/spec#727