You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Modified error handling in ExtractionManager.scala to gracefully handle missing mapping namespaces for unsupported languages. Instead of throwing NoSuchElementException, the code now uses optional namespace resolution with early exits, logging warnings, and returning empty mappings when namespaces are unavailable.
Changes
Cohort / File(s)
Summary
Error Handling for Missing Namespaces server/src/main/scala/org/dbpedia/extraction/server/ExtractionManager.scala
Replaced mandatory namespace retrieval with optional approach using Some for "wikidata" and .get() fallback. Added early exit when namespace is missing with warning log. Centralized source selection logic to check local file existence before loading from server, with appropriate warning logs for missing files or local file usage.
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
✅ Passed
The title directly summarizes the main change: handling missing mapping namespaces gracefully instead of throwing exceptions.
Linked Issues check
✅ Passed
The PR implements the required fix for issue #827 by handling languages without mapping namespaces gracefully and logging warnings instead of throwing exceptions.
Out of Scope Changes check
✅ Passed
All changes in ExtractionManager.scala are directly scoped to resolving the missing mapping namespace issue and preventing server startup crashes.
Docstring Coverage
✅ Passed
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches🧪 Generate unit tests (beta)
Create PR with unit tests
Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a server startup crash when enabling languages that do not have
mapping namespaces (e.g. fi, et, lt).
Instead of throwing NoSuchElementException, such languages are now logged
and skipped.
Fixes #827
Summary by CodeRabbit