docs: opaque white background and larger annotations in pipeline.svg#168
Merged
MilagrosMarin merged 1 commit intomainfrom May 5, 2026
Merged
docs: opaque white background and larger annotations in pipeline.svg#168MilagrosMarin merged 1 commit intomainfrom
MilagrosMarin merged 1 commit intomainfrom
Conversation
Mirror the dark-mode fix from datajoint-python#1448: - Add an opaque white background rect covering the full viewBox so the right-side annotations remain legible against any page theme. - Bump annotation font size from 17 to 19 to keep effective rendered size in the 9-11pt range at typical column widths. Without this, the code panel had its own white rect but the surrounding annotations sat on transparent — invisible in dark mode.
MilagrosMarin
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors the dark-mode fix from datajoint-python#1448, addressing the same review feedback:
<rect>covering the full SVG viewBox so the entire illustration (annotations included) reads against white regardless of page theme. Previously the code panel had its own white rect but the surrounding annotations sat on transparent — black text on a black background made them invisible in dark mode.Test plan
mkdocs serveand load/— confirm the illustration renders correctly.