Added validation for CSCws84232#334
Open
veenaskumar-cisco wants to merge 19 commits intodatacenter:v4.1.0-devfrom
Open
Added validation for CSCws84232#334veenaskumar-cisco wants to merge 19 commits intodatacenter:v4.1.0-devfrom
veenaskumar-cisco wants to merge 19 commits intodatacenter:v4.1.0-devfrom
Conversation
veenaskumar-cisco
force-pushed
the
CSCws84232
branch
4 times, most recently
from
38634fd to
7fa5de3
Compare
|
this is not an outage warning. this will allow the upgrade to complete but GUi will be slow with defect after upgrade. So we should say MANUAL CHECK REQUIRED |
lovkeshsharma702
left a comment
lovkeshsharma702
left a comment
There was a problem hiding this comment.
missing code for svccoreNode. these 2 mo need to be checked.
lovkeshsharma702
left a comment
lovkeshsharma702
left a comment
There was a problem hiding this comment.
please check with comment section. make sure we handle these.
veenaskumar-cisco
force-pushed
the
CSCws84232
branch
from
c26882d to
32289d3
Compare
Author
|
lovkeshsharma702
approved these changes
Mar 11, 2026
|
pytest logs: |
lovkeshsharma702
suggested changes
May 8, 2026
lovkeshsharma702
approved these changes
May 8, 2026
monrog2
requested changes
May 8, 2026
| headers = ['svccoreCtrlr Object Count','svccoreNode Object Count'] | ||
| data = [] | ||
| recommended_action = "Delete the core files before proceeding with upgrade. Please refer to the document linked below and contact Cisco TAC for assistance if needed." | ||
| doc_url = "https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations/#svccore_excessive_data_check" |
Collaborator
There was a problem hiding this comment.
fix the link to match the shortcut name in the validations doc
| prints(msg) | ||
| log.error(msg, exc_info=True) | ||
| sys.exit(1) | ||
| sys.exit(1) No newline at end of file |
Collaborator
There was a problem hiding this comment.
keep modifications scoped to the ticket, if this needs to change, file a separate issue
| [Fabric Link Redundancy][g17] | :white_check_mark: | :no_entry_sign: | ||
| [APIC Database Size][g18] | :white_check_mark: | :no_entry_sign: | ||
| [APIC downgrade compatibility when crossing 6.2 release][g19]| :white_check_mark: | :no_entry_sign: | ||
| [Svccore Excessive Data Check][g20] | :white_check_mark: | |
Collaborator
There was a problem hiding this comment.
put no entry sign if not on built-in.
@takishida do we need to mass update these to account for 6.2 having the ability to pull latest + once metadat offline bundle it available for pull?
|
|
||
| ### Svccore Excessive Data Check | ||
|
|
||
| Due to excessive `svccoreCtrlr` or `svccoreNode` managed objects, Apic gui stuck in loading multiple queries. |
Collaborator
There was a problem hiding this comment.
add a line indicating what those objects actually represent.
| "moCount": { | ||
| "attributes": { | ||
| "childAction": "", | ||
| "count": "32000", |
Collaborator
There was a problem hiding this comment.
flip positive and negative checks. positive = hitting condition, negative = not hitting (PASS)
| [ | ||
| # No excessive class entries | ||
| ( | ||
| {svccoreClassEntry: read_data(dir, "svccore_positive.json"),svccoreNodeEntry: read_data(dir, "svccoreNode_positive.json")}, |
Collaborator
There was a problem hiding this comment.
modify these pointers after pos/neg files are flipped
| @check_wrapper(check_title="svccore excessive data check") | ||
| def svccore_excessive_data_check(**kwargs): | ||
| result = PASS | ||
| headers = ['svccoreCtrlr Object Count','svccoreNode Object Count'] |
Collaborator
There was a problem hiding this comment.
make the columnes more agnostic, such as [ClassName, Count].
Ten you can only have rows where they exceed your criteria;
ClassName, Count
svccore, 251
or
ClassName, Count
svccore, 251
scvother 500
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #333
Fail logs:
POST UPGRADE CHECK REQUIRED : 0
N/A : 0
ERROR !! : 0
TOTAL : 1