Fix swapped tag/branch flag bindings in bundle init#5510
Open
simonfaltum wants to merge 1 commit into
Open
Conversation
The --tag flag was bound to the branch variable and --branch to the tag variable. Behavior is unchanged today because both collapse into a single git ref in the template resolver, but the crossed bindings would break any future code that distinguishes tags from branches. Co-authored-by: Isaac
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Collaborator
|
Commit: 55226ec
22 interesting tests: 15 SKIP, 7 KNOWN
Top 28 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Found during a full-repo review of the CLI. In
bundle init, the--tagflag is bound to thebranchvariable and--branchto thetagvariable. Behavior is unaffected today because the template resolver collapses both into a single git ref, but the crossed bindings are a landmine for any future code that treats tags and branches differently.Changes
Before,
--tagwrote into thebranchvariable and--branchinto thetagvariable; now each flag is bound to its matching variable. Two-line swap of the pointer arguments incmd/bundle/init.go. No user-visible behavior change.Test plan
go build ./cmd/bundle/...go test ./cmd/bundle/...go test ./libs/template(existing resolver tests cover the tag/branch handling downstream)./task fmt-q,./task lint-q,./task checksThis pull request and its description were written by Isaac.