feat(key-wallet): seed sync checkpoint from birth_height#693
feat(key-wallet): seed sync checkpoint from birth_height#693xdustinface wants to merge 1 commit intov0.42-devfrom
birth_height#693Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v0.42-dev #693 +/- ##
=============================================
+ Coverage 70.47% 70.60% +0.13%
=============================================
Files 206 320 +114
Lines 43946 68028 +24082
=============================================
+ Hits 30971 48032 +17061
- Misses 12975 19996 +7021
|
973115f to
5ee6537
Compare
|
This PR has merge conflicts with the base branch. Please rebase or merge the base branch into your branch to resolve them. |
5ee6537 to
0a49ef4
Compare
Move sync checkpoint seeding into `ManagedWalletInfo` construction so it can't be forgotten, and let callers control the scan range when importing. - `WalletInfoInterface::from_wallet` now takes `birth_height` and seeds `synced_height` and `last_processed_height` to `birth_height.saturating_sub(1)`. Previously every wallet-add path had to remember to call `set_birth_height` separately, and forgetting it dragged `WalletManager::synced_height` (a min across wallets) back to genesis on every add. - `WalletManager::import_wallet_from_extended_priv_key`, `import_wallet_from_xpub`, and `import_wallet_from_bytes` (plus the matching FFI) gain a `birth_height` parameter so previously-used keys can rescan from a chosen height instead of being silently anchored at the chain tip. - Unused `ManagedWalletInfo::with_birth_height` removed.
50c6a0d to
92aa0ba
Compare
WalletManager::import_wallet_from_extended_priv_key,import_wallet_from_xpub, andimport_wallet_from_bytes(plus the matching FFI) gain abirth_heightparameter so previously-used keys can rescan from a chosen height instead of being silently anchored at the chain tip.Based on:
birth_heightinManagedWalletInfoctors #692