fix(shared): close squad share modal after external link post#5978
Merged
rebelchris merged 2 commits intomainfrom May 4, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rebelchris
deleted the
eng-1358-feedback-feature-request-modal-does-not-close-after-posting
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Key Decisions
onCompletecallback inusePostToSquadso the external-link path can signal success without fabricating aPostobjectonPostSuccessreserved for flows that actually return aPostCreateSharedPostModalback to lazy-modal props to keep the close path simpleCloses ENG-1358
Created by Huginn 🐦⬛
Preview domain
https://eng-1358-feedback-feature-reques.preview.app.daily.dev