fix(chlorinator): telemetry doesn't properly represent operating mode#140
Merged
Conversation
cryptk
force-pushed
the
fix_chlorinator_mode
branch
from
77ffbad to
c497134
Compare
BREAKING CHANGE: Chlorinator set_op_mode takes ChlorinatorMSPConfigMode now
cryptk
force-pushed
the
fix_chlorinator_mode
branch
from
c497134 to
663ca42
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Chlorinator set_op_mode takes ChlorinatorMSPConfigMode instead of ChlorinatorOperatingMode
This is because there seems to be some discrepancy between the mode reported in telemetry and the mode reported in the MSP Config data. The telemetry seems to lag behind the MSP Config, sometimes significantly. Perhaps the MSP Config data is what the requested mode is while the telemetry is what the current mode is, and there is some delay for the system to change modes.