feat(pump,filter): add support for dual speed pumps and filters#139
Merged
feat(pump,filter): add support for dual speed pumps and filters#139
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds set_dual_speed control methods to both filters and pumps that can be used as a helper function for controlling dual speed units. The previous set_speed control method could also be used just specifying a value of 0, 50 or 100, but this helper function accepts values from the SpeedPreset enums to make things a bit more semantically simple to use.
This adds the support needed for cryptk/haomnilogic-local#81