Skip to content

Fix #14696 FP passedByValueCallback, constParameterCallback for constructor #8497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −1
Open

Fix #14696 FP passedByValueCallback, constParameterCallback for constructor #8497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d34080
Update symboldatabase.cpp
chrchr-github Apr 27, 2026
5a3582e
Update testother.cpp
chrchr-github Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/symboldatabase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1203,7 +1203,7 @@ void SymbolDatabase::createSymbolDatabaseSetFunctionPointers(bool firstPass)

tok->function(function);

if (tok->strAt(1) != "(")
if (!function->isConstructor() && tok->strAt(1) != "(")
const_cast<Function *>(function)->functionPointerUsage = tok;
}
}
Expand Down
10 changes: 10 additions & 0 deletions test/testother.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4150,6 +4150,16 @@ class TestOther : public TestFixture {
" S s2{ cb };\n"
"}\n");
ASSERT_EQUALS("[test.cpp:6:11] -> [test.cpp:2:21]: (performance) Function parameter 's' should be passed by const reference. However it seems that 'cb' is a callback function. [passedByValueCallback]\n", errout_str());

check("struct S {\n" // #14696
" explicit S(std::string s = {}) {}\n"
"};\n"
"struct T {\n"
" explicit T(std::string* s = {}) {}\n"
"};\n");
ASSERT_EQUALS("[test.cpp:2:28]: (performance) Function parameter 's' should be passed by const reference. [passedByValue]\n"
"[test.cpp:5:29]: (style) Parameter 's' can be declared as pointer to const [constParameterPointer]\n",
errout_str());
}

void constPointer() {
Expand Down
Loading