feat(ui): add extra-small size to Button component#1644
Open
MartinS-git wants to merge 14 commits intomainfrom
Open
feat(ui): add extra-small size to Button component#1644MartinS-git wants to merge 14 commits intomainfrom
MartinS-git wants to merge 14 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: d146f0c The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an extra-small size variant to the Button component in ui-components, wires it into a real usage example (DataGridToolbar story), and extends stories/tests to cover the new size.
Changes:
- Extend
ButtonSizewith"extra-small"and add size-specific typography/padding/icon sizing logic. - Adjust in-progress icon rendering (Spinner) to better control spacing/margins.
- Add Storybook stories + unit tests for the new size and update DataGridToolbar story to use it.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| packages/ui-components/src/components/Button/Button.component.tsx | Implements the new extra-small size, refactors sizing helpers, and adjusts Spinner/icon handling. |
| packages/ui-components/src/components/Button/Button.stories.tsx | Adds ExtraSmall stories and updates some story descriptions. |
| packages/ui-components/src/components/Button/Button.test.tsx | Adds unit tests for extra-small rendering and progress state. |
| packages/ui-components/src/components/DataGridToolbar/DataGridToolbar.stories.tsx | Updates toolbar story to showcase an extra-small Button in a constrained layout. |
Contributor
|
TilmanHaupt
previously approved these changes
Apr 30, 2026
MartinS-git
force-pushed
the
ui-button-xs
branch
from
31baad7 to
9c4e1ef
Compare
edda
reviewed
Apr 30, 2026
Signed-off-by: MartinS-git <info@eyepic.de>
Signed-off-by: MartinS-git <info@eyepic.de>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: MartinS-git <info@eyepic.de>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: MartinS-git <info@eyepic.de>
Signed-off-by: MartinS-git <info@eyepic.de>
- Add marginRight prop to Spinner to make built-in margin configurable - Button uses marginRight prop instead of className hack (jn:!mr-0) - Update extra-small padding to px-1.5 - Update DataGridToolbar story label to "Clear Filters" - Add tests for Spinner marginRight prop Signed-off-by: Martin Schulze <martin.schulze04@sap.com> Signed-off-by: MartinS-git <info@eyepic.de>
…ange Signed-off-by: Martin Schulze <martin.schulze04@sap.com> Signed-off-by: MartinS-git <info@eyepic.de>
- Rename ButtonSize "extra-small" to "xs" for consistency - Revert Spinner marginRight prop (to be handled in separate PR) - Use Spinner className prop instead for icon spacing in Button - Update Button test to match new "juno-button-xs-size" class name Signed-off-by: MartinS-git <info@eyepic.de>
Signed-off-by: MartinS-git <info@eyepic.de>
Signed-off-by: MartinS-git <info@eyepic.de>
Signed-off-by: MartinS-git <info@eyepic.de>
Signed-off-by: MartinS-git <info@eyepic.de>
63 tasks
edda
previously approved these changes
May 7, 2026
Contributor
edda
left a comment
edda
left a comment
There was a problem hiding this comment.
Other than the valid comment by Copilot regarding line-height for the xs button, looking very good now!
Signed-off-by: MartinS-git <info@eyepic.de>
Signed-off-by: MartinS-git <info@eyepic.de>
edda
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xsas a newButtonSizevariantgetButtonBase()andiconSize()as helper functions (replacing inline ternaries)XS,XSWithIcon, andXSInProgressstoriesDataGridToolbarstory: "Clear Filters" button now usessize="xs"Closes #1638