Skip to content

Bumped libbuildpack-dynatrace to Support File-Based VCAP Services#1261

Open
wepudt wants to merge 2 commits intocloudfoundry:mainfrom
wepudt:add-dt-filepath-vcap-service-support
Open

Bumped libbuildpack-dynatrace to Support File-Based VCAP Services#1261
wepudt wants to merge 2 commits intocloudfoundry:mainfrom
wepudt:add-dt-filepath-vcap-service-support

Conversation

@wepudt
Copy link
Copy Markdown

@wepudt wepudt commented May 4, 2026

  • Bumped version of libbuildpack-dynatrace to v1.9.0 to introduce support for file-path based VCAP Services to Dynatrace injection.

  • This allows the use of file-path based VCAP Service feature while injecting apps with Dynatrace OneAgent.


  • I have viewed signed and have submitted the Contributor License Agreement -> Links to the documents are dead and search did not turn up any documents. To my knowledge this is covered by corporate agreement.

  • I have made this pull request to the master branch

  • I have added an integration test -> no new integration test required.

@ramonskie
Copy link
Copy Markdown
Contributor

why are the changes within libbuildpack it self?.
while libbuildpack has not been bumped

@wepudt wepudt changed the title Bumped DT libbuildpack to Support File-Based VCAP Services Bumped libbuildpack-dynatrace to Support File-Based VCAP Services May 4, 2026
@wepudt
Copy link
Copy Markdown
Author

wepudt commented May 4, 2026

why are the changes within libbuildpack it self?. while libbuildpack has not been bumped

Perhaps my title was misleading -> I fixed it.

I updated go.mod libbuildpack-dynatrace from release v1.8.0 to release v1.9.0 that contains the logic to support File-based VCAP Services for Dynatrace OneAgent injection (release notes.

@ramonskie
Copy link
Copy Markdown
Contributor

i was talking about the changes within
vendor/github.com/cloudfoundry/libbuildpack/installer.go

vendor/github.com/cloudfoundry/libbuildpack/manifest.go

these changes should not exists.
and libbuildpack should also be bumped in the appdynamics repo as it still points to a really old version

@wepudt
Copy link
Copy Markdown
Author

wepudt commented May 5, 2026

i was talking about the changes within vendor/github.com/cloudfoundry/libbuildpack/installer.go

vendor/github.com/cloudfoundry/libbuildpack/manifest.go

these changes should not exists. and libbuildpack should also be bumped in the

I think these changes are from 90abbc2.
I just ran go mod vendor after bumping libbuildpack-dynatrace to v1.9.0 and it bumped the vendor files to 20260415084012-70e599bbe72c.
Would you prefer to do this in a separate PR?

and libbuildpack should also be bumped in the appdynamics repo as it still points to a really old version

What do you mean by that?

@ramonskie
Copy link
Copy Markdown
Contributor

those changes within libbuildpack should not be there.
and it think this is happening due to a very old dependecy on libbuildpack see https://github.com/Dynatrace/libbuildpack-dynatrace/blob/master/go.mod#L6
this is version from 2021
so i think when we bump that the problem is solved.

@wepudt
Copy link
Copy Markdown
Author

wepudt commented May 5, 2026

those changes within libbuildpack should not be there. and it think this is happening due to a very old dependecy on libbuildpack see https://github.com/Dynatrace/libbuildpack-dynatrace/blob/master/go.mod#L6 this is version from 2021 so i think when we bump that the problem is solved.

I restored the orignial vendor files of libuildpack.

As commit 90abbc2 introduced a divergence in the vendor files you should fix that by running go mod vendor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants