Fix MySQL backwards compatibility test failure#5085
Merged
philippthun merged 1 commit intocloudfoundry:mainfrom May 5, 2026
Merged
Conversation
Sequel::Postgres::Dataset is only defined when the postgres adapter is loaded. In regular CI, the case_insensitive_string_monkeypatch requires sequel/adapters/postgres unconditionally, making the constant available even in MySQL runs. The backwards compatibility tests skip migrations (NO_DB_MIGRATION=true), so the monkeypatch is never loaded and the constant is undefined. Use Sequel::Dataset instead, which is always available and sufficient for the mock (it only needs .update).
5 tasks
kathap
approved these changes
May 5, 2026
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
May 5, 2026
Changes in cloud_controller_ng:
- Fix MySQL backwards compatibility test failure
PR: cloudfoundry/cloud_controller_ng#5085
Author: Philipp Thun <philipp.thun@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sequel::Postgres::Datasetis only defined when the postgres adapter is loaded. In regular CI, thecase_insensitive_string_monkeypatchrequiressequel/adapters/postgresunconditionally, making the constant available even in MySQL runs. The backwards compatibility tests skip migrations (NO_DB_MIGRATION=true), so the monkeypatch is never loaded and the constant is undefined.Use
Sequel::Datasetinstead, which is always available and sufficient for the mock (it only needs.update).I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests